New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[folding] Endregion case-sensitive depending on case Region is specified in #35506

Closed
mikefrobbins opened this Issue Oct 2, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@mikefrobbins

mikefrobbins commented Oct 2, 2017

  • VSCode Version: Code - Insiders 1.17.0-insider (7ac1f1e, 2017-09-30T05:06:21.234Z)
  • OS Version: Windows_NT x64 10.0.15063
  • Extensions:
Extension Author (truncated) Version
PowerShell ms- 1.4.3

The endregion keyword must be specified in lower case when region is specified in lower case. Endregion is not case sensitive when region is specified in proper, mixed, or upper case. For more details see: http://mikefrobbins.com/2017/10/02/regions-are-now-available-in-vscode-as-of-insiders-build-version-1-17-0/


Steps to Reproduce:

  1. Specify region in lower case.
  2. Specify endregion in anything other than lower case.

@vscodebot vscodebot bot added the editor label Oct 2, 2017

@aeschli aeschli assigned aeschli and unassigned alexandrudima Oct 3, 2017

@aeschli

This comment has been minimized.

Show comment
Hide comment
@aeschli
Contributor

aeschli commented Oct 3, 2017

@aeschli aeschli changed the title from Endregion case-sensitive depending on case Region is specified in to [folding] Endregion case-sensitive depending on case Region is specified in Oct 3, 2017

@aeschli aeschli added this to the September 2017 milestone Oct 3, 2017

@mikefrobbins

This comment has been minimized.

Show comment
Hide comment
@mikefrobbins

mikefrobbins Oct 3, 2017

That's funny, I just realized that I wrote the blog article that's referenced in the previous comment by @aeschli

mikefrobbins commented Oct 3, 2017

That's funny, I just realized that I wrote the blog article that's referenced in the previous comment by @aeschli

@aeschli

This comment has been minimized.

Show comment
Hide comment
@aeschli

aeschli Oct 5, 2017

Contributor

I verified that in the Powershell ISE #region and #endregion must be all in lowercase, so I assume that's how is designed.
Closing, but I'm happy to change it to whatever the spec says.

Contributor

aeschli commented Oct 5, 2017

I verified that in the Powershell ISE #region and #endregion must be all in lowercase, so I assume that's how is designed.
Closing, but I'm happy to change it to whatever the spec says.

@aeschli aeschli closed this Oct 5, 2017

@mikefrobbins

This comment has been minimized.

Show comment
Hide comment
@mikefrobbins

mikefrobbins Oct 5, 2017

@aeschli based on your comment for closing this issue, it has not been resolved and is not working as designed.
In VSCode insiders build version 1.17.0, regions work when specified in a case other than lower case which based on your comment is not how it's designed. You should only be able to use lower case.

mikefrobbins commented Oct 5, 2017

@aeschli based on your comment for closing this issue, it has not been resolved and is not working as designed.
In VSCode insiders build version 1.17.0, regions work when specified in a case other than lower case which based on your comment is not how it's designed. You should only be able to use lower case.

@aeschli

This comment has been minimized.

Show comment
Hide comment
@aeschli

aeschli Oct 5, 2017

Contributor

Note that indentation based folding is also active. That's likely what you are seeing.
If not, please add a sample.

Contributor

aeschli commented Oct 5, 2017

Note that indentation based folding is also active. That's likely what you are seeing.
If not, please add a sample.

@mikefrobbins

This comment has been minimized.

Show comment
Hide comment
@mikefrobbins

mikefrobbins Oct 5, 2017

`#Region
    <#
    Region can be upper, proper, or mixed case with no problem. This should not
    work, but it does.
    #>
#endregion`

mikefrobbins commented Oct 5, 2017

`#Region
    <#
    Region can be upper, proper, or mixed case with no problem. This should not
    work, but it does.
    #>
#endregion`
@aeschli

This comment has been minimized.

Show comment
Hide comment
@aeschli

aeschli Oct 6, 2017

Contributor

@mikefrobbins That's because the line below #Region has a larger indent. The normal folding by indentation rules apply.
What's new with the added folding marker support is that these work regardless of indent, e.g:
image
but not
image

Contributor

aeschli commented Oct 6, 2017

@mikefrobbins That's because the line below #Region has a larger indent. The normal folding by indentation rules apply.
What's new with the added folding marker support is that these work regardless of indent, e.g:
image
but not
image

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 19, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.