Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New terminal lines rendering cuts off bottom/top of characters like underscore #35901

Open
viktorku opened this issue Oct 9, 2017 · 87 comments

Comments

@viktorku
Copy link

commented Oct 9, 2017

The new terminal rendering cuts off the bottom part of "long" characters, such as g, j and y.

1.17.0:
image

1.17.1:
image

  • VSCode Version: 1.17.0
Version 1.17.0
Commit be377c0faf7574a59f84940f593a6849f12e4de7
Date 2017-10-04T23:33:45.303Z
Shell 1.7.7
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64
  • OS Version: Ubuntu Trusty 14.04

Steps to Reproduce:

  1. Open the Terminal
  2. Start typing git checkout -b feature/object

Reproduces without extensions: Yes

@fpauser

This comment has been minimized.

Copy link

commented Oct 9, 2017

Same problem here.

@ahmadkelsherif

This comment has been minimized.

Copy link

commented Oct 9, 2017

similar to #35794 but on fedora it cuts off the top part

@masonj88

This comment has been minimized.

Copy link

commented Oct 9, 2017

Chops the top off on Fedora 26.
badterminal

@imgss

This comment has been minimized.

Copy link

commented Oct 10, 2017

Same problem here.

@ivcosla

This comment has been minimized.

Copy link

commented Oct 10, 2017

I just changed the "terminal.integrated.fontFamily" value. My issue was that underscores were not displayed using DejaVu Sans Mono. With other fonts they are displaying, not sure if it would help to fix your problem guys, but sure is worth to give it a try.

@jashworth

This comment has been minimized.

Copy link

commented Oct 10, 2017

The variable width font that I'm partial to now renders like this.

image

@chrmarti chrmarti removed the new release label Oct 10, 2017
@Tyriar

This comment has been minimized.

Copy link
Member

commented Oct 10, 2017

@Tyriar Tyriar added the bug label Oct 10, 2017
@Tyriar

This comment has been minimized.

Copy link
Member

commented Oct 10, 2017

@viktorku what's in your settings.json file?

@viktorku

This comment has been minimized.

Copy link
Author

commented Oct 11, 2017

In 1.17.1 the rendering changed (it's somewhat blurrier and smaller fontsize - see top comment for comparison) but the bug prevails:

image

@Tyriar This also happens for a fresh code instance (without settings.json in the project's root .vscode). My User Settings are like this:

{
    "workbench.sideBar.location": "left",
    "files.exclude": {
        "**/.git*": false,
        "**/.svn": true,
        "**/.hg": true,
        "**/.DS_Store": true,
        "**/.tags*": true,
	"**/.pyc": true,
        ".catkin_tools/**/packages": true,
        "build": true,
        "devel": true,
        "logs": true,
        "src/external": true,
        "**/CMakeLists.txt.user": true,
        "**/__pycache__": true
    },

    "editor.fontSize": 12,
    "editor.tabSize": 2,
    "editor.wordWrap": "on",
    "editor.rulers": [
        100
    ],

    "[python]": {
        "editor.tabSize": 4
    },

    "files.trimTrailingWhitespace": true,
    "diffEditor.ignoreTrimWhitespace": false,

    "workbench.editor.enablePreviewFromQuickOpen": false,

    "window.zoomLevel": 0,

    "clang-format.executable": "/usr/bin/clang-format-3.8",
    "clang-format.style": "Google",
    "clang-format.language.javascript.enable": false,

    "prettier.printWidth": 100,
    "prettier.singleQuote": true,
    "prettier.bracketSpacing": true,
    "workbench.colorTheme": "One Dark Pro",

    "editor.multiCursorModifier": "alt",
    "git.ignoreLegacyWarning": true,
    "workbench.startupEditor": "newUntitledFile",

    "eslint.nodePath": "/home/viktor/.nvm/versions/node/v7.4.0/bin/node",

    "python.linting.pylintArgs": [
        "--load-plugins pylint-django"
    ]
}
@viktorku viktorku changed the title New terminal rendering lines cut off bottom of long characters New terminal lines rendering cuts off bottom of long characters Oct 11, 2017
@mpartipilo

This comment has been minimized.

Copy link

commented Oct 18, 2017

Similar issue. Image here: #36322 (comment)

@Tyriar

This comment has been minimized.

Copy link
Member

commented Oct 18, 2017

Using the insiders build I believe you can workaround this currently by setting:

"terminal.integrated.lineHeight": 1.1
@CoenraadS

This comment has been minimized.

Copy link
Contributor

commented Oct 31, 2017

@Tyriar

The line height workaround doesn't work for me in latest insiders

Running Ubuntu in virtualbox

  • VSCode Version: Code - Insiders 1.18.0-insider (81cca6c, 2017-10-31T06:24:27.011Z)
  • OS Version: Linux x64 4.10.0-37-generic

In my screenshot I typed some underscores _________
image

I also tried crazy heights like 2 but nothing seems to help

This is a regression from 1.17 where it displays fine:
image

Setting terminal.integrated.fontSize": 13 is a workaround for me

@simon387

This comment has been minimized.

Copy link

commented Nov 3, 2017

yeah, fixed on fedora26 VSC 1.17.2 Shell 1.7.7 with the terminal.integrated.fontSize option

@DannyMexen

This comment has been minimized.

Copy link

commented Nov 9, 2017

Ubuntu 17.10 here and terminal.integrated.fontSize solved it. Thanks, everyone.

@mattwelke

This comment has been minimized.

Copy link

commented Jul 4, 2019

@Tyriar Looks like I can't comment on #46879 because it's locked. If it's unlocked, I'll leave a detailed comment with all the relevant info.

@Tyriar

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

Unlocked, meant to when I reopened

@mattwelke

This comment has been minimized.

Copy link

commented Jul 4, 2019

@Tyriar Left a detailed comment.

@nileshjain166

This comment has been minimized.

Copy link

commented Aug 12, 2019

setting "terminal.integrated.fontSize" to 15 shows the underscore character for me.

@hugonasciutti

This comment has been minimized.

Copy link

commented Aug 12, 2019

setting "terminal.integrated.fontSize" to 15 shows the underscore character for me.

It does not make sense to show only in higher font size, we need to fix it. But good to know the value, it could help debug.

@pjfitzgerald

This comment has been minimized.

Copy link

commented Aug 22, 2019

Any progress on this issue?

@terislos

This comment has been minimized.

Copy link

commented Aug 23, 2019

Any progress on this issue?

None, continue the problem. :/

@dullroar

This comment has been minimized.

Copy link

commented Aug 25, 2019

On Linux (Mint 19.2) installing the Inconsolata font and making it the first in the font list (and restarting VS Code) fixed the terminal window issue for me. I know that's not a "fix" but for those reading this thread who want a font "That Just Works" maybe that will help until it is fixed. FWIW, Linux Mint's editor, Xed, has had a similar issue - linuxmint/xed#39.

@axi92

This comment has been minimized.

Copy link

commented Sep 5, 2019

I have the same problem
Reproduce: echo "___" into terminal

Workaround for me is in the settings:
"terminal.integrated.fontFamily": "monospace"

Version: 1.37.1
Commit: f06011a
Datum: 2019-08-15T16:17:25.463Z
Electron: 4.2.7
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
Betriebssystem: Linux x64 4.15.0-60-generic

@Nirusu

This comment has been minimized.

Copy link

commented Sep 6, 2019

Same issue here on Ubuntu 18.04 and latest (1.38.0) Visual Studio code. "terminal.integrated.fontFamily": "monospace" provides a good workaround, but a fix would be very appreciated :/

Version: 1.38.0
Commit: 3db7e09
Date: 2019-09-03T21:51:09.716Z
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Linux x64 4.15.0-60-generic

@kwahab

This comment has been minimized.

Copy link

commented Sep 22, 2019

Simply setting terminal font to Hack on Kubuntu 18.04 fixed it for me.
"terminal.integrated.fontFamily": "Hack"

@Remzi1993

This comment has been minimized.

Copy link

commented Sep 24, 2019

When gets this fixed? It's a issue from 2 years ago already!
I don't understand why it's not a priority.

Setting: terminal.integrated.fontSize to 15 fixed the issue.
Maybe, make this font size the default? This could be an option.

@Kryptoxic

This comment has been minimized.

Copy link

commented Sep 26, 2019

I work a lot in a linux environment compared to windows environment so when changing over from windows, I always get irritated that I cant see the underscores and I see that this has been going on for two years already. Commenting so I can follow this issue to see it fixed.

@ghost

This comment has been minimized.

Copy link

commented Oct 1, 2019

I'm not using vscode, but I'm seeing this issue on ArchLinux in both Chromium and Hexchat with certain font-sizes only, but not only with DejaVu Sans Mono (Book) but also with Noto Sans Mono but way less visible. Tested for chars: qpjy_. With Noto the underscore is always visible, but other chars can be seen cut off a bit.

Inconsolata(and/or Nimbus Mono PS too) font however seems to exhibit no such issues. Hence why I'm switching my Monospace font to it.

$ fc-match monospace
Inconsolata-Regular.ttf: "Inconsolata" "Regular"

This here is an interesting read as to why this descenders cut off might be happening.
Another interesting comment with some workarounds possibly.

@bprosnitz

This comment has been minimized.

Copy link

commented Oct 10, 2019

Setting font size to 13.9 (from the default of 14) fixed underscores for me.

@Tyriar

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

The current thing blocking this is stabilizing the WebGL renderer, see upstream query: https://github.com/xtermjs/xterm.js/issues?q=is%3Aopen+is%3Aissue+label%3Aarea%2Faddon%2Fwebgl

@suntaoTs

This comment has been minimized.

Copy link

commented Oct 22, 2019

@Tyriar

The line height workaround doesn't work for me in latest insiders

Running Ubuntu in virtualbox

  • VSCode Version: Code - Insiders 1.18.0-insider (81cca6c, 2017-10-31T06:24:27.011Z)
  • OS Version: Linux x64 4.10.0-37-generic

In my screenshot I typed some underscores _________
image

I also tried crazy heights like 2 but nothing seems to help

This is a regression from 1.17 where it displays fine:
image

Setting terminal.integrated.fontSize": 13 is a workaround for me

fontSize: 13 and fontSize: 15 all can solve this problem. just advise that the default Size not be 14, it will be solved.

@jbracer19

This comment was marked as spam.

Copy link

commented Oct 22, 2019

@jbracer19

This comment was marked as spam.

Copy link

commented Oct 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.