New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Clear Recently Opened" should also clear editor quick pick history #35935

Closed
axefrog opened this Issue Oct 9, 2017 · 5 comments

Comments

Projects
None yet
6 participants
@axefrog

axefrog commented Oct 9, 2017

  • VSCode Version: 1.17.0
  • OS Version: Windows 10

Steps to Reproduce:

  1. Open a file to get it into quick open's "recently opened" suggestions
  2. Close the file
  3. Press CTRL+P; start typing the filename and it should show up with the label "recently opened"
  4. Bring up the command bar and select "clear recently opened"
  5. The file is gone from the file menu's recently opened files, but not from the quick open bar

vscode-clear-recently-opened

I understand that the command bar's recently opened suggestions are a separate feature to the recent files list in the file menu, but I'd say that:

  1. They may be separate in terms of implementation, but they are probably the same from the user's perspective. Clearing one should probably clear the other.
  2. Even if they stay separate, the nomenclature should be changed - the hint text displayed to the right of the file in quick open is "recently opened"; providing a "clear recently opened" command creates confusion, given that the latter has no effect on the former.

@vscodebot vscodebot bot added the new release label Oct 9, 2017

@vscodebot vscodebot bot added the workbench label Oct 9, 2017

@axefrog axefrog changed the title from Confusing relationship between "clear recently opened" and quick open's "recently opened" label to Confusing relationship between "clear recently opened" and quick open's "recently opened" hint text Oct 9, 2017

@sandy081 sandy081 assigned bpasero and unassigned sandy081 Oct 10, 2017

@chrmarti chrmarti removed the new release label Oct 10, 2017

@bpasero bpasero changed the title from Confusing relationship between "clear recently opened" and quick open's "recently opened" hint text to "Clear Recently Opened" should also clear editor quick pick history Oct 11, 2017

@bpasero bpasero removed their assignment Oct 11, 2017

@bpasero bpasero removed the workbench label Nov 16, 2017

@jemhuntr

This comment has been minimized.

Show comment
Hide comment
@jemhuntr

jemhuntr Apr 4, 2018

Would love this feature! This always bites me when I rename a folder and all the Ctrl+P results fire a File Not Found error.

As a workaround though, the solution from #3260 (comment) works for me.

jemhuntr commented Apr 4, 2018

Would love this feature! This always bites me when I rename a folder and all the Ctrl+P results fire a File Not Found error.

As a workaround though, the solution from #3260 (comment) works for me.

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Apr 6, 2018

Member

It is easily possible to clear the editor history of Cmp+P, just use this:

image

You can even remove individual entries:

image

Member

bpasero commented Apr 6, 2018

It is easily possible to clear the editor history of Cmp+P, just use this:

image

You can even remove individual entries:

image

@bpasero bpasero self-assigned this Sep 12, 2018

@bpasero bpasero added this to the September 2018 milestone Sep 12, 2018

@bpasero bpasero closed this in 6fb9cc9 Sep 12, 2018

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Sep 12, 2018

Member

Picking "Clear Recently Opened" will now also remove "recently used" from the picker.

Member

bpasero commented Sep 12, 2018

Picking "Clear Recently Opened" will now also remove "recently used" from the picker.

@isidorn

This comment has been minimized.

Show comment
Hide comment
@isidorn

isidorn Sep 25, 2018

Contributor

@bpasero I verified that the Clear Editor History and remove from history properly remove editors from the quick pick history.
However clicking on Clear Recently Opened in the menu does not modify the quick open editor history. Should I reopen?

Contributor

isidorn commented Sep 25, 2018

@bpasero I verified that the Clear Editor History and remove from history properly remove editors from the quick pick history.
However clicking on Clear Recently Opened in the menu does not modify the quick open editor history. Should I reopen?

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Sep 25, 2018

Member

@isidorn good catch

Member

bpasero commented Sep 25, 2018

@isidorn good catch

@bpasero bpasero reopened this Sep 25, 2018

@bpasero bpasero closed this in 1950014 Sep 26, 2018

@isidorn isidorn added the verified label Sep 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment