New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use search.followSymlinks for all searches #37000

Closed
roblourens opened this Issue Oct 26, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@roblourens
Member

roblourens commented Oct 26, 2017

search.followSymlinks is hooked up for searches using QueryBuilder (find in files, quickopen) but not searches initiated by extensions, or from workspaceContains. Maybe it should be.

Pro: A nice lever for people to have when they are having trouble with symlinks e.g. from cnpm/pnpm. Also, if the user has indicated that they have a setup where it doesn't make sense for their searches to follow symlinks, then the same should apply for other searches.

Con: User settings should not impact extensions in this case

cc @chrmarti I said I would file this last week

@roblourens roblourens added the search label Oct 26, 2017

@roblourens roblourens added this to the October 2017 milestone Oct 26, 2017

@roblourens roblourens self-assigned this Oct 26, 2017

@chrmarti

This comment has been minimized.

Contributor

chrmarti commented Oct 26, 2017

Sounds good to me. We can refine it later if there is any need.

@chrmarti

This comment has been minimized.

Contributor

chrmarti commented Oct 30, 2017

Thanks!

@roblourens roblourens changed the title from Maybe use search.followSymlinks for all searches to Use search.followSymlinks for all searches Oct 30, 2017

@chrmarti chrmarti added the verified label Nov 2, 2017

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 13, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.