New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workbench contribution for a LifecyclePhase #38080

Closed
jrieken opened this Issue Nov 10, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@jrieken
Member

jrieken commented Nov 10, 2017

Extracted from #37541:

@jrieken now that we have the startup phases in lifecycle service, should we change registerWorkbenchContribution to accept an optional phase argument and then when we instantiate the contributions respect that event to delay the instantiation?

Yeah, the registry should be per-phase and we should revisit each contribution and decide in which phase it should get created. Maybe even add another phase like RunningForABit so dust can settle..

This would need to be wired into the setInstantiationService call of the BaseRegistry I guess.

Unsure... Not even sure what that is but feels we leak a layer to low. I would suggest to have an instance of those per phase and hide the idea of phases from it

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Nov 13, 2017

Member

@jrieken fyi I added LifecyclePhase.RunningForABit (via fa592ef). The delay is a bit artifical (3s via workbench startup). I adopted this for WorkspaceStats.

I also made NodeCachedDataManager a IWorkbenchContribution but currently this one is executed as before on LifecyclePhase.Running. Not sure if that one should be delayed as well.

Member

bpasero commented Nov 13, 2017

@jrieken fyi I added LifecyclePhase.RunningForABit (via fa592ef). The delay is a bit artifical (3s via workbench startup). I adopted this for WorkspaceStats.

I also made NodeCachedDataManager a IWorkbenchContribution but currently this one is executed as before on LifecyclePhase.Running. Not sure if that one should be delayed as well.

@jrieken

This comment has been minimized.

Show comment
Hide comment
@jrieken

jrieken Nov 14, 2017

Member

I also made NodeCachedDataManager a IWorkbenchContribution but currently this one is executed as before on LifecyclePhase.Running. Not sure if that one should be delayed as well.

That can be delayed safely

Member

jrieken commented Nov 14, 2017

I also made NodeCachedDataManager a IWorkbenchContribution but currently this one is executed as before on LifecyclePhase.Running. Not sure if that one should be delayed as well.

That can be delayed safely

bpasero added a commit that referenced this issue Nov 14, 2017

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 29, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.