New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command line command to install wont install if newer version already installed #38609

Closed
hilleer opened this Issue Nov 17, 2017 · 6 comments

Comments

Projects
None yet
5 participants
@hilleer

hilleer commented Nov 17, 2017

  • VSCode Version: 1.18.1
  • OS Version: macOS High Sierra 10.13.1

Steps to Reproduce:

  1. Have two identical vsix files of an extension, but with different version tags. I made two test ones here: (https://github.com/hilleer/vscode-install-cli-test-vsixs)[https://github.com/hilleer/vscode-install-cli-test-vsixs]
  2. Install the latest (version 1.1.0 from the example ones`) from within vscode or from the command line.
  3. Reload / check that the extension is installed (1.1.0)
  4. Install the old version (version 1.0.0 from the example ones) from the command line (`code --install-extension ).
  5. Reload vscode, and check the version of the extension - still the version of the first (newest) installed version.

Reproduces without extensions: Yes/No

@sandy081

This comment has been minimized.

Show comment
Hide comment
@sandy081

sandy081 Nov 22, 2017

Member

We generally do not support installing outdated extensions from gallery. But I think it makes sense to support it for vsix installations.

If you are trying to install an older versions using vsix, now, we show a confirmation asking to override the newer version with older version.

Member

sandy081 commented Nov 22, 2017

We generally do not support installing outdated extensions from gallery. But I think it makes sense to support it for vsix installations.

If you are trying to install an older versions using vsix, now, we show a confirmation asking to override the newer version with older version.

@sandy081

This comment has been minimized.

Show comment
Hide comment
@sandy081

sandy081 Nov 22, 2017

Member

@joaomoreno As part of this fix, I had to flip the order of extensions clean up. Now, I remove first obsolete extensions and then remove outdated extensions 4fb98ff. Want to know if the previous order had any reason?

Member

sandy081 commented Nov 22, 2017

@joaomoreno As part of this fix, I had to flip the order of extensions clean up. Now, I remove first obsolete extensions and then remove outdated extensions 4fb98ff. Want to know if the previous order had any reason?

@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Nov 23, 2017

Member

No reason! 👍

Member

joaomoreno commented Nov 23, 2017

No reason! 👍

@hilleer

This comment has been minimized.

Show comment
Hide comment
@hilleer

hilleer Nov 27, 2017

Thanks for implementing this! 👍

hilleer commented Nov 27, 2017

Thanks for implementing this! 👍

@ramya-rao-a

This comment has been minimized.

Show comment
Hide comment
@ramya-rao-a

ramya-rao-a Dec 5, 2017

Member

@sandy081 Verified that this works after confirming the override.
But when I press 1 for Cancel, there is a callstack printed out

image

Member

ramya-rao-a commented Dec 5, 2017

@sandy081 Verified that this works after confirming the override.
But when I press 1 for Cancel, there is a callstack printed out

image

@ramya-rao-a ramya-rao-a reopened this Dec 5, 2017

@sandy081

This comment has been minimized.

Show comment
Hide comment
@sandy081

sandy081 Dec 6, 2017

Member

Good catch @ramya-rao-a

Fixed.

image

Member

sandy081 commented Dec 6, 2017

Good catch @ramya-rao-a

Fixed.

image

@sandy081 sandy081 closed this Dec 6, 2017

sandy081 added a commit that referenced this issue Dec 6, 2017

@rebornix rebornix added the verified label Dec 7, 2017

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 20, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.