New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open File: unable to open a file with spaces in name if absolute path is provided #42726

Closed
bpasero opened this Issue Feb 1, 2018 · 9 comments

Comments

Projects
None yet
7 participants
@bpasero
Member

bpasero commented Feb 1, 2018

Steps to Reproduce:

  1. open quick open (Cmd+P)
  2. paste the absolute path of an existing file that contains spaces (for me: C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js)

=> no results shown to open

@bpasero bpasero added bug search labels Feb 1, 2018

@chrmarti chrmarti added this to the February 2018 milestone Feb 2, 2018

aushakou added a commit to aushakou/vscode that referenced this issue Feb 13, 2018

aushakou added a commit to aushakou/vscode that referenced this issue Feb 13, 2018

@humphd

This comment has been minimized.

humphd commented Feb 13, 2018

I was teaching my students about workflows for fixing bugs in VSCode, and used this bug as an example. I wrote them a guide at https://github.com/humphd/vscode/tree/good-first-experience-issue-42726#walkthrough-fixing-a-bug-in-visual-studio-code.

I was going to do a PR, but it looks like one of them beat me to it, so I'll let @aushakou continue.

@bpasero bpasero assigned bpasero and unassigned roblourens and chrmarti Feb 14, 2018

@bpasero

This comment has been minimized.

Member

bpasero commented Feb 14, 2018

Good findings 👍

@tsalinger

This comment has been minimized.

Contributor

tsalinger commented Mar 1, 2018

Doesn't work for me. Tested on Win10 and Ubuntu

@tsalinger tsalinger reopened this Mar 1, 2018

@bpasero bpasero assigned roblourens and chrmarti and unassigned bpasero Mar 2, 2018

@bpasero bpasero modified the milestones: February 2018, March 2018 Mar 2, 2018

@bpasero

This comment has been minimized.

Member

bpasero commented Mar 2, 2018

@roblourens @chrmarti this probably got lost when moving to RipGrep for search. The idea is that a full absolute path of an existing file should always return a result, at least from quick open (not sure about other use cases). Let me know if this should be baked into the file-search or if we should add this to the picker as a special case and let the search service behave as before.

@chrmarti

This comment has been minimized.

Contributor

chrmarti commented Mar 2, 2018

This works when there are no spaces in the path on Mac. So the code is still there, we just need to fix it.

@bpasero

This comment has been minimized.

Member

bpasero commented Mar 2, 2018

@chrmarti can you point me to the code?

@bpasero

This comment has been minimized.

Member

bpasero commented Mar 2, 2018

@chrmarti thanks, my fix was not complete it seems.

@bpasero bpasero self-assigned this Mar 2, 2018

@bpasero bpasero removed this from the March 2018 milestone Mar 2, 2018

@Owen-Mak

This comment has been minimized.

Owen-Mak commented Apr 21, 2018

I submitted a PR to fix this issue here, but I put down the wrong issue number during the submission, which is why I am referencing it in this comment now.
The PR fixes the spacing problem mentioned above, and has been tested on windows 7 and Fedora 25.

@bpasero bpasero added this to the On Deck milestone May 11, 2018

@bpasero bpasero modified the milestones: On Deck, June 2018 Jun 11, 2018

@bpasero bpasero closed this Jun 11, 2018

bpasero added a commit that referenced this issue Jun 11, 2018

@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 26, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.