New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customisation of debug toolbar (eg. additional buttons) #45116

Open
DanTup opened this Issue Mar 6, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@DanTup

DanTup commented Mar 6, 2018

In Flutter (a framework for developing mobile apps) we have two different types of restart during debugging:

  1. Stateful Hot Reload
  2. Full Restart

Since stateful hot reload is awesome, we've wired that up to the Restart button on the toolbar. In the case where this fails (eg. because you modified something that makes your state invalid) we have a status bar notification and an action in the command palette for a "Full Restart".

This has been a little confusing for users - they expect to see buttons for "Hot Reload" and "Restart" on the toolbar.

It would be great if we could supply an icon/tooltip for additional buttons (and a way of positioning them between existing buttons) and have it run a custom command.

@DanTup DanTup changed the title from Aloow customisation of debug toolbar (eg. additional buttons) to Allow customisation of debug toolbar (eg. additional buttons) Mar 6, 2018

@weinand weinand added the debug label Mar 6, 2018

@weinand weinand self-assigned this Mar 6, 2018

@weinand weinand added this to the On Deck milestone Mar 6, 2018

@isidorn

This comment has been minimized.

Contributor

isidorn commented Mar 6, 2018

This is a fair feature request.
We already have the editor title area where extensions can contribute actions and icons
Here's an example of markdown doing it.

So we would need to introduce a new menu id for the debug toolbar. For example 'debug/actionBar' - since we already call it actionbar in settings.
Positioning would be done by using the "group" property, so nothing new to introduce for this.

A nice thing about this is that we would be able to remove the chakra actions which do not really belong in the vscode core imho.

@weinand

This comment has been minimized.

Member

weinand commented Mar 6, 2018

@isidorn Sorry, but there are no "chakra actions". The debug protocol supports reverse-back and reverse-continue and VS Code surfaces that in the UI. VS Code does not know anything about chakra (and the comment is wrong). Any debug extension can use that. So there is no way that we ever remove support for this.

@DanTup

This comment has been minimized.

DanTup commented Mar 6, 2018

Reverse continue?! That sounds bizzare!

So we would need to introduce a new menu id for the debug toolbar. For example 'debug/actionBar'

I was actually thinking this would work by sending a customRequest or similar to the DA (so it's similar to restartRequest), though since we have two-way communication between UI and DA now it doesn't worry me too much how it'd work.

@DanTup

This comment has been minimized.

DanTup commented Dec 10, 2018

@isidorn @weinand Do you think this is something that might happen anytime soon? I'm considering adding a setting to allow the user to control whether the Restart button will trigger a Reload or a Restart as a workaround, but it'd be much better if we could just give them both.

@weinand

This comment has been minimized.

Member

weinand commented Dec 10, 2018

@DanTup We are investigating this is the Dec/Jan milestone.

@DanTup

This comment has been minimized.

DanTup commented Dec 10, 2018

@weinand Ok cool, I'll hang fire doing anything until it's clear if this may happen - thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment