New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Japanese Input (IME) on Mac - Suggestions Overlap w/ Text #45629

Open
chibicode opened this Issue Mar 13, 2018 · 16 comments

Comments

Projects
None yet
@chibicode
Copy link

chibicode commented Mar 13, 2018

  • VSCode Version: 1.21.0
  • OS Version: macOS 10.13.1

Steps to Reproduce:

  1. Install Google Japanese Input https://www.google.co.jp/intl/ja/ime/
  2. Activate it
  3. Open a new VSCode instance
  4. Type konnnichiha on keyboard, then hit enter, and do it again a few times
  5. Expected: the suggestions should never overlap w/ text. Actual: the suggestions overlap w/ text.

See the GIF:

screen recording 2018-03-12 at 08 03 pm

Does this issue occur when all extensions are disabled?: Yes

Notes:

This is not an issue with the default Japanese IME that comes w/ macOS.


Update (Sep 27, 2018): Workaround

This setting seems to fix the issue. (You'll lose some functionalities)

@vscodebot vscodebot bot added the new release label Mar 13, 2018

@Yamotty

This comment has been minimized.

Copy link

Yamotty commented Mar 13, 2018

Same Here

@mashriq

This comment has been minimized.

Copy link

mashriq commented Mar 13, 2018

same here

@CM-Kajiwara

This comment has been minimized.

Copy link

CM-Kajiwara commented Mar 13, 2018

Same Here

@vscodebot vscodebot bot removed the new release label Mar 13, 2018

@jrieken jrieken assigned ramya-rao-a and unassigned jrieken Mar 13, 2018

@ramya-rao-a

This comment has been minimized.

Copy link
Member

ramya-rao-a commented Mar 13, 2018

@jrieken The suggestion box that shows up in this case is not the one for suggestWidget. This seems like a native control which I dont believe VS Code controls

cc @rebornix @octref

@chibicode @Yamotty @mashriq @CM-Kajiwara Is this a regression? Did this work as expected in earlier versions of VS Code and stopped working recently?

@rebornix

This comment has been minimized.

Copy link
Member

rebornix commented Mar 13, 2018

I think it is probably caused by the position adjustment of the textarea, Google IME tries to put the candidate list at the proper position, but I don't have a stable reproduce yet.

@chibicode

This comment has been minimized.

Copy link

chibicode commented Mar 13, 2018

Sorry, I am a new user to VSCode so not sure if this is a regression.

@octref

This comment has been minimized.

Copy link
Member

octref commented Mar 13, 2018

@rebornix I can repro it consistently.

image

@chibicode

This comment has been minimized.

Copy link

chibicode commented Jul 23, 2018

Not just VSCode but Adobe Brackets seems to have the same issue as well - and for that, apparently, the issue is on CodeMirror:
codemirror/CodeMirror#4089

If it's an Electron issue not sure if upgrading Electron to 2.x or 3.x fixes it. #45542

This was not an issue on Atom (even when Atom was using Electron 1.x).

@chibicode

This comment has been minimized.

Copy link

chibicode commented Jul 23, 2018

I also searched through Twitter, and people have been reporting this since April 2015. Definitely not a regression. @ramya-rao-a @rebornix

https://twitter.com/shohaga/status/593568407301193728
https://twitter.com/hiedar83/status/593676327665860608
https://twitter.com/tyamaz/status/593728561392984064

@hiramatsu

This comment has been minimized.

Copy link

hiramatsu commented Aug 24, 2018

Same Here

@rebornix

2018-08-24 12 03 06
2018-08-24 12 03 35

@chibicode

This comment has been minimized.

Copy link

chibicode commented Sep 5, 2018

@rebornix @octref Is there anything I can do to help?

Also saw this reported on Teratail, a Japanese Stackoverflow clone, about a week ago.
https://teratail.com/questions/143100

@hiramatsu

This comment has been minimized.

Copy link

hiramatsu commented Sep 26, 2018

※日本語で失礼します。

暫定的(temporary)な回避策(workaround)ですが、「Google 日本語入力 環境設定」の「サジェスト」タブの
・入力履歴からのサジェスト自動表示を有効にする
・リアルタイム変換を有効にする
のチェックを外せば被らなくなりました。(上記機能は失われますが…)
2018-09-26 11 51 35

@chibicode

This comment has been minimized.

Copy link

chibicode commented Sep 26, 2018

Translating what @hiramatsu said:

Temporary workaround: go to Google Japanese Input preferences,

screen shot 2018-09-26 at 6 58 30 pm

go to サジェスト ("suggest") and uncheck

  • 入力履歴からのサジェスト自動表示を有効にする (disable suggestion from input history)
  • リアルタイム変換を有効にする (disable live conversion)

Then click 適用 button at the bottom.

Then it no longer overlaps.

@rebornix

This comment has been minimized.

Copy link
Member

rebornix commented Sep 26, 2018

@hiramatsu @chibicode thanks for your help. This issue was caused by how we implement our editor (virtualize everything but has a tiny textarea around the virtual cursor) and Google IME doesn't work the same as the OS builtin IME. I don't have a good idea how to hint Google IME about the position but your solution works perfectly for this issue.

For anyone who is using English as system language, the preference with the workaround will look like below:

image

@rebornix rebornix added this to the Backlog milestone Sep 26, 2018

@rebornix rebornix removed their assignment Sep 26, 2018

@chibicode

This comment has been minimized.

Copy link

chibicode commented Sep 27, 2018

@rebornix thanks for the follow-up!

Just for completeness: Google maintains "a subset of Google Japanese Input in the form of source code under OSS license without any warranty nor user support" at google/mozc (more explanation), though they're not accepting pull requests at the moment.

@yujikuroki

This comment has been minimized.

Copy link

yujikuroki commented Oct 5, 2018

Same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment