New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt user to change the language of the UI after the installation of a localization pack #45872

Closed
qcz opened this Issue Mar 15, 2018 · 9 comments

Comments

@qcz
Copy link
Contributor

qcz commented Mar 15, 2018

If a beginner user installs a localization pack from the extension manager viewlet, they must read the description of the extension to find out how they can activate it. It would be great if there would be an easy mechanism to activate the extension (change the required value in locale.json).

@vscodebot

This comment has been minimized.

Copy link

vscodebot bot commented Mar 15, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@dbaeumer

This comment has been minimized.

Copy link
Member

dbaeumer commented Mar 16, 2018

@sandy081 this makes sense to me. Is this something you can do on installing a language pack. We could ask the user to make it the default UI language and the simply update the locale.json file in the user settings directory.

@dbaeumer dbaeumer added this to the March 2018 milestone Mar 16, 2018

@dbaeumer

This comment has been minimized.

Copy link
Member

dbaeumer commented Mar 16, 2018

I set this to March since it would be something we should do to round the LP story.

@sandy081

This comment has been minimized.

Copy link
Member

sandy081 commented Mar 19, 2018

@dbaeumer Yes, can be done. What if an extension has multiple languages? If not urgent, I would postpone it to April?

@qcz

This comment has been minimized.

Copy link
Contributor

qcz commented Mar 19, 2018

@sandy081: Why not handle the case where the package contains only one language for starters? Language packs generated from the community provided translations on Transifex are all single language packages. The user experience for activating them is currently not beginner friendly.

@sandy081

This comment has been minimized.

Copy link
Member

sandy081 commented Mar 19, 2018

Makes sense. I can add this support as a stretch 💪

@sandy081

This comment has been minimized.

Copy link
Member

sandy081 commented Mar 21, 2018

@dbaeumer Does the following prompt makes sense?

image

May I know if I can test this while running out of the dev? Updating the language in the locale.json file and restarting is not running the dev with update locale.

sandy081 added a commit that referenced this issue Mar 21, 2018

@dbaeumer

This comment has been minimized.

Copy link
Member

dbaeumer commented Mar 21, 2018

@sandy081 message makes sense but I would do a little tweak to change VS Code's UI language to.

You can't test this out of dev only in a build version. In dev mode we only have English since we don't do any code rewriting there.

sandy081 added a commit that referenced this issue Mar 21, 2018

@sandy081

This comment has been minimized.

Copy link
Member

sandy081 commented Mar 21, 2018

Tested this in the generated build

@sandy081 sandy081 closed this Mar 21, 2018

@vscodebot vscodebot bot locked and limited conversation to collaborators May 5, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.