Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With no file in focus, "Reveal in Finder" should open the workspace's folder #46785

Closed
garyking opened this issue Mar 28, 2018 · 3 comments
Closed

With no file in focus, "Reveal in Finder" should open the workspace's folder #46785

garyking opened this issue Mar 28, 2018 · 3 comments
Assignees
@isidorn
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues help wanted Issues identified as good community contribution opportunities release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2018

Comments

@garyking
Copy link

With no file in focus, if I use the Command Palette and choose "Reveal in Finder", then the workspace's folder should be opened. If it's a workspace, of course.
@vscodebot
Copy link

vscodebot bot commented Mar 28, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@bpasero bpasero assigned isidorn and unassigned bpasero Mar 28, 2018
@isidorn
Copy link
Contributor

isidorn commented Mar 28, 2018

This is a fair feature request.
PR that fix this are welcome code pointer https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/files/electron-browser/fileCommands.ts#L393

@isidorn isidorn added help wanted Issues identified as good community contribution opportunities feature-request Request for new features or functionality labels Mar 28, 2018
@isidorn isidorn removed their assignment Mar 28, 2018
@isidorn isidorn added the file-explorer Explorer widget issues label Mar 28, 2018
@isidorn isidorn added this to the Backlog milestone Mar 28, 2018
@pradeepmurugesan pradeepmurugesan mentioned this issue Apr 2, 2018
Merged
@isidorn isidorn modified the milestones: Backlog, April 2018 Apr 20, 2018
@isidorn isidorn self-assigned this Apr 20, 2018
@isidorn isidorn added the verification-needed Verification of issue is requested label Apr 20, 2018
isidorn added a commit that referenced this issue Apr 20, 2018
@isidorn
Merge pull request #47090 from pradeepmurugesan/reveal-in-finder-root…
c857328 
…-folder

#46785 open root folder when no file is in focus and reveal in finder
@isidorn
Copy link
Contributor

isidorn commented Apr 20, 2018

Fixed via #47090

@isidorn isidorn closed this as completed Apr 20, 2018
@isidorn isidorn added verified Verification succeeded release-notes Release notes issues labels Apr 24, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues help wanted Issues identified as good community contribution opportunities release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
3 participants
@garyking @bpasero @isidorn