New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode sends search keystrokes to Microsoft even with telemetry disabled #49161

Open
taoeffect opened this Issue May 4, 2018 · 6 comments

Comments

Projects
None yet
7 participants
@taoeffect

taoeffect commented May 4, 2018

  • VSCode Version: Insider build on May 3, 2018
  • OS Version: macOS

Steps to Reproduce:

  1. Download latest insider build
  2. Run
  3. Disable telemetry settings and restart VSCode
  4. Open a file (or in my case, the settings), and do Command+F to search, and search for something

Does this issue occur when all extensions are disabled?: didn't try


VSCode will attempt to connect to Bing as you search:

screen shot 2018-05-03 at 8 00 30 pm

@vscodebot vscodebot bot added the search label May 4, 2018

@dd86k

This comment has been minimized.

Show comment
Hide comment
@dd86k

dd86k May 4, 2018

If this can't even be disabled as an internal extension, which I doubt it is, then it's a major issue. No surprise by the confusion made at the the beginning of the VS Code product (not project) regarding licensing (which you mentioned in your toot).

VS Code is my Tool of the Trade, but unfortunately if I have to fork and let aside my current projets, I won't get any happier.

dd86k commented May 4, 2018

If this can't even be disabled as an internal extension, which I doubt it is, then it's a major issue. No surprise by the confusion made at the the beginning of the VS Code product (not project) regarding licensing (which you mentioned in your toot).

VS Code is my Tool of the Trade, but unfortunately if I have to fork and let aside my current projets, I won't get any happier.

@DickvdBrink

This comment has been minimized.

Show comment
Hide comment
@DickvdBrink

DickvdBrink May 4, 2018

Contributor

Lol, probably just an oversight because they made the search a lot better
(https://code.visualstudio.com/blogs/2018/04/25/bing-settings-search).

So I think it only does this on the settings file and not on other files ;)

Contributor

DickvdBrink commented May 4, 2018

Lol, probably just an oversight because they made the search a lot better
(https://code.visualstudio.com/blogs/2018/04/25/bing-settings-search).

So I think it only does this on the settings file and not on other files ;)

@darshanrampatel

This comment has been minimized.

Show comment
Hide comment
@darshanrampatel

darshanrampatel commented May 4, 2018

Duplicate of #44294

@roblourens

This comment has been minimized.

Show comment
Hide comment
@roblourens

roblourens May 4, 2018

Member

Yes, it can be disabled with "workbench.settings.enableNaturalLanguageSearch": false

Member

roblourens commented May 4, 2018

Yes, it can be disabled with "workbench.settings.enableNaturalLanguageSearch": false

@marmistrz

This comment has been minimized.

Show comment
Hide comment
@marmistrz

marmistrz May 4, 2018

This should definitely be an opt-in!

marmistrz commented May 4, 2018

This should definitely be an opt-in!

@levrik

This comment has been minimized.

Show comment
Hide comment
@levrik

levrik May 4, 2018

@roblourens I agree with @marmistrz. Maybe show an notification the first time a user opens the settings page to ask if they want to activate this. It should make clear that with that enabled data is sent to Microsoft servers.

levrik commented May 4, 2018

@roblourens I agree with @marmistrz. Maybe show an notification the first time a user opens the settings page to ask if they want to activate this. It should make clear that with that enabled data is sent to Microsoft servers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment