New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional breakpoint prompt should offer to enable (not disable) breakpoints if breakpoint is already disabled #50569

Closed
DanTup opened this Issue May 28, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@DanTup

DanTup commented May 28, 2018

  • Create a conditional breakpoint
  • Click on the breakpoint in the gutter to get the "Disable instead of remove?" prompt
  • Click "Disable breakpoint"
  • Click on the breakpoint again in the gutter

The dialog that pops up asks if you want to disable the breakpoint instead of removing it; but it's already disabled. It would be better to ask if the user wants to remove it or enable it since it feels quite natural to re-enable it via the path you disabled it.

@vscodebot

This comment has been minimized.

Show comment
Hide comment
@isidorn

This comment has been minimized.

Show comment
Hide comment
@isidorn

isidorn May 28, 2018

Contributor

This is a fair feature request and we accept PRs that fix this.
Code pointer

this.dialogService.show(severity.Info, nls.localize('breakpointHasCondition', "This {0} has a {1} that will get lost on remove. Consider disabling the {0} instead.",

Contributor

isidorn commented May 28, 2018

This is a fair feature request and we accept PRs that fix this.
Code pointer

this.dialogService.show(severity.Info, nls.localize('breakpointHasCondition', "This {0} has a {1} that will get lost on remove. Consider disabling the {0} instead.",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment