New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG, CSS, Emmet] suggestion color if said "#" like "id".... #56082

Closed
Mlocik97-issues opened this Issue Aug 9, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@Mlocik97-issues

Mlocik97-issues commented Aug 9, 2018

Issue Type: Bug
if I don't write selector in root scope but for example in media query, it suggest colors and attributes.

#42245

bez nazvu

VS Code version: Code 1.25.1 (1dfc5e5, 2018-07-11T15:43:53.668Z)
OS version: Windows_NT x64 10.0.17134

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2808)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: disabled_software
video_decode: enabled
video_encode: enabled
vpx_decode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 15.88GB (10.83GB free)
Process Argv C:\Program Files\Microsoft VS Code\Code.exe
Screen Reader no
VM 0%
Extensions: none

@ramya-rao-a ramya-rao-a self-assigned this Aug 9, 2018

@ramya-rao-a ramya-rao-a added the emmet label Aug 9, 2018

@ramya-rao-a ramya-rao-a added the bug label Sep 12, 2018

@ramya-rao-a ramya-rao-a added this to the On Deck milestone Sep 12, 2018

ramya-rao-a added a commit to Microsoft/vscode-emmet-helper that referenced this issue Sep 14, 2018

@ramya-rao-a

This comment has been minimized.

Show comment
Hide comment
@ramya-rao-a

ramya-rao-a Sep 14, 2018

Member

That position is a valid position for both css property/value as well as a css rule.
So, I cannot prevent emmet altogether in that position.

But # followed by anything that is not a hexadecimal is an invalid abbreviation, so I've pushed a fix for that.

So, ul#123abc is valid but ul#something is not

Member

ramya-rao-a commented Sep 14, 2018

That position is a valid position for both css property/value as well as a css rule.
So, I cannot prevent emmet altogether in that position.

But # followed by anything that is not a hexadecimal is an invalid abbreviation, so I've pushed a fix for that.

So, ul#123abc is valid but ul#something is not

@ramya-rao-a ramya-rao-a modified the milestones: On Deck, September 2018 Sep 14, 2018

@jrieken jrieken added the verified label Sep 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment