Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Editors: revisit order of groups to be based on visual order #56084

Closed
bpasero opened this issue Aug 9, 2018 · 4 comments

Comments

@bpasero
Copy link
Member

commented Aug 9, 2018

Extracted from: #54916

Instead of ordering groups by creation time, order them by visual appearance.

@bpasero

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2018

@isidorn actually I wonder if we should revisit this decision. Every other command (Cmd+1, 2, 3) and also the Go > Switch Group > Group 1, 2, 3 works in visual grid order and not history order. We could just do the same for the "open editors" view and it would probably be OK for most cases.

The thing that makes me want to revisit this is that a simple flow like the following one produces a very confusing result:

before

I just dropped the group to the left of the empty one and it becomes Group 2.

@bpasero bpasero changed the title Open Editors: provide a setting to show groups in visual order Open Editors: revisit order of groups to be based on visual order Aug 9, 2018

@isidorn

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2018

Yeah I also find this use case confusing.
We can change it in insiders and try it out for a couple of weeks to see how it feels when we follow the visual order.

@bpasero

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2018

Opened #56264

@bpasero bpasero closed this Aug 15, 2018

bpasero added a commit that referenced this issue Aug 15, 2018

@bpasero

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2018

Verify:

  • open a group
  • open a group to the side
  • open some editors in each group
  • open a third group between the 2 groups

=> the formerly called group 2 should now be called group 3 and the new group 2 should be in between group 1 and 3 (same as the visual order).

@isidorn isidorn added the verified label Aug 28, 2018

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.