New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings UI should remember its search upon reload #57289

Closed
sbatten opened this Issue Aug 27, 2018 · 3 comments

Comments

@sbatten
Member

sbatten commented Aug 27, 2018

Issue Type: Feature Request

Some settings require reload and this may be in the middle of the user modifying settings. It would be cool if the settings UI could remember the search through reload.

@roblourens

This comment has been minimized.

Member

roblourens commented Sep 24, 2018

#58499

I would say "the search should be persisted when reloading with the settings editor open".

@roblourens

This comment has been minimized.

Member

roblourens commented Sep 24, 2018

PR welcome.

  • Use getEditorMemento to cache the search string of the settings editor (settingsEditor2.ts)
  • Implement setVisible, the state should only be cached or restored if the settings editor was visible when the window reloaded.
@roblourens

This comment has been minimized.

Member

roblourens commented Sep 24, 2018

Besides the search string, this should also cover the scroll position of the settings list per #57365. If that turns out to be hard, it can be a separate PR...

@roblourens roblourens closed this Oct 6, 2018

@roblourens roblourens added this to the October 2018 milestone Oct 6, 2018

@sandy081 sandy081 added the verified label Nov 1, 2018

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 20, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.