New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhelpful message when no settings are found #57321

Closed
jrieken opened this Issue Aug 28, 2018 · 5 comments

Comments

@jrieken
Member

jrieken commented Aug 28, 2018

re #57304

Search for something that doesn't match any setting. In comparison to search, the message is a little short and unfriendly. For instance, it could offer to undo some filters.

screen shot 2018-08-28 at 09 21 16

better

screen shot 2018-08-28 at 09 22 35

@roblourens

This comment has been minimized.

Member

roblourens commented Aug 28, 2018

I'm not sure, would a button to clear the input field be helpful? Or remove the @ filters but leave the rest of the query?

@jrieken

This comment has been minimized.

Member

jrieken commented Aug 28, 2018

Both? A link for clearing @-filters and one for clearing the rest. Or know which on to remove by already testing them with changes in the background.

@roblourens

This comment has been minimized.

Member

roblourens commented Aug 28, 2018

Is that really useful though? Search needs it because people collapse the query details then forget that it's searching somewhere else, or don't know how to get rid of the filter. Here, there is clearly a text box and the user just typed in it.

@vscodebot

This comment has been minimized.

vscodebot bot commented Sep 5, 2018

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@roblourens

This comment has been minimized.

Member

roblourens commented Sep 24, 2018

Would take a PR that adds two link/buttons to that message, one to remove filters (when filters are present), the other to clear the whole search string.

NiclasvanEyk added a commit to NiclasvanEyk/vscode that referenced this issue Oct 1, 2018

roblourens added a commit that referenced this issue Oct 5, 2018

Merge pull request #59739 from NiclasvanEyk/master
Added actions from #57321 to the 'No Settings Found'-message

@roblourens roblourens added this to the October 2018 milestone Oct 6, 2018

@roblourens roblourens closed this Oct 11, 2018

@RMacfarlane RMacfarlane added the verified label Nov 1, 2018

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.