Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom titleBarStyle breaks mouse cursor in editor #58383

Closed
G-Ray opened this issue Sep 10, 2018 · 6 comments
Closed

custom titleBarStyle breaks mouse cursor in editor #58383

G-Ray opened this issue Sep 10, 2018 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug electron Issues and items related to Electron linux Issues with VS Code on Linux titlebar VS Code main title bar issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded

Comments

@G-Ray
Copy link

G-Ray commented Sep 10, 2018

  • VSCode Version: v1.27.1
  • OS Version: Fedora 28
  • screen: 3200x1800px

Steps to Reproduce:

  1. Set window.titleBarStyle="custom"
  2. restart vscode in a window
  3. The cursor mouse does not work everywhere in the editor.

Gif demonstrating the issue: https://i.imgur.com/vQi0iWV.gif

The issue does not happen when vs code is in fullscreen, or when titleBarStyle is set to "native".
The issue does not appear on another computer on Fedora 28 too, with a 1080p screen.

@vscodebot vscodebot bot removed the new release label Sep 11, 2018
@sbatten sbatten added info-needed Issue requires more information from poster bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Sep 11, 2018
@sbatten
Copy link
Member

sbatten commented Sep 11, 2018

@G-Ray can you reliably repro this with the custom title bar enabled? Is it possible to reproduce this with the native title bar?

@G-Ray
Copy link
Author

G-Ray commented Sep 12, 2018

@sbatten Here are some more info:

  • I can repro this 100% when custom title bar is enabled + my gnome desktop display settings scale the display at 200%. As my laptop screen is 3200x1800, I always use a scaling setting of 200%. No issue when vscode is in fullscreen mode.

  • No issue when scaling is set to 100%.

  • when titlebar is native, I can't repro the issue, no matter what is the scaling percentage.

I guess when the style is native vscode uses gtk3, and there is no issues at all with the way gnome/gtk are scaling the app for hidpi screens. However when the titleBar is set to custom, gtk libs may not be loaded, and this causes this issue ?

@G-Ray
Copy link
Author

G-Ray commented Sep 24, 2018

@sbatten Any news ? Can you reproduce this behavior in a GNU/Linux distro ?

@sbatten
Copy link
Member

sbatten commented Sep 24, 2018

@G-Ray thanks for the extra info, I was able to repro the issue in Electron as well and have reported upstream: electron/electron#14787

@sbatten sbatten added upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron titlebar VS Code main title bar issues labels Sep 24, 2018
@sbatten sbatten added the linux Issues with VS Code on Linux label Nov 14, 2018
@joaomoreno
Copy link
Member

This appears to be fixed on today's VS Code Insiders, which is based on Electron 6.0.9! 🎆

Can you confirm @sbatten?

@sbatten
Copy link
Member

sbatten commented Sep 25, 2019

confirmed

@sbatten sbatten closed this as completed Sep 25, 2019
@sbatten sbatten added this to the September 2019 milestone Sep 25, 2019
@sbatten sbatten added verified Verification succeeded fixed-in-electron-6.0.x labels Sep 25, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug electron Issues and items related to Electron linux Issues with VS Code on Linux titlebar VS Code main title bar issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants