New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Workspace button in .code-workspace files #59305

Closed
isidorn opened this Issue Sep 25, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@isidorn
Contributor

isidorn commented Sep 25, 2018

It would be great if we showed a button to Open Workspace floating in .code-workspace files.
This will help the users easily open the workspace if they accidently opened a .code-workspace file.
You should just use the FloatingClickWidget
Here's an example how I do this for launch.json here

@bpasero

This comment has been minimized.

Member

bpasero commented Sep 25, 2018

Needs #59308 (ideally). But I would accept a reasonably small PR for this if someone wants to chime in. Idea is to show a blue button in every .code-workspace file to open that workspace.

@bpasero bpasero added the help wanted label Sep 25, 2018

jgbright added a commit to jgbright/vscode that referenced this issue Sep 28, 2018

@bpasero bpasero modified the milestones: On Deck, October 2018 Sep 28, 2018

bpasero added a commit that referenced this issue Sep 28, 2018

@bpasero bpasero removed the help wanted label Sep 28, 2018

@bpasero

This comment has been minimized.

Member

bpasero commented Sep 28, 2018

image

@isidorn

This comment has been minimized.

Contributor

isidorn commented Sep 28, 2018

Fancyyyy

@bpasero bpasero closed this in 0c4fa8a Oct 1, 2018

JimiC added a commit to JimiC/vscode that referenced this issue Oct 5, 2018

October changes (Microsoft#59712)
* fix Microsoft#59597

* fix Microsoft#59552

* fix Microsoft#57997

* Open Workspace button in .code-workspace files (fixes Microsoft#59305)

* debt - filename => filepath to make method clear
@bpasero

This comment has been minimized.

Member

bpasero commented Oct 26, 2018

Verification: open a workspace file as file and verify you see a button to "Open Workspace" and clicking it will open the workspace.

@mjbvz mjbvz added the verified label Oct 31, 2018

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 15, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.