New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git: Symlink support #5970

Open
mrded opened this Issue Apr 29, 2016 · 8 comments

Comments

Projects
None yet
4 participants
@mrded

mrded commented Apr 29, 2016

  • VSCode Version: 1.0.0 (1.0.0)
  • OS Version: OSX 10.11.4 (15E65)

Steps to Reproduce:

  1. Create a new project with git repository initialised.
  2. Create a folder /foo/bar
  3. Add a symlink from /foo/bar to /bar ln -s /foo/bar .
  4. Go to Git tab on vscode, and stage /bar folder.

If now you click on staged /bar folder, you'll get an error Warn: Can't open this git resource.

@jeremyjjbrown

This comment has been minimized.

Show comment
Hide comment
@jeremyjjbrown

jeremyjjbrown Jun 2, 2016

It would be nice to find nested git repos as well. Some of us are fortunate enough to not code on Monoliths.

jeremyjjbrown commented Jun 2, 2016

It would be nice to find nested git repos as well. Some of us are fortunate enough to not code on Monoliths.

@joaomoreno joaomoreno added this to the Backlog milestone Jun 3, 2016

@mightypenguin

This comment has been minimized.

Show comment
Hide comment
@mightypenguin

mightypenguin Sep 14, 2016

It would be nice to have an option to NOT do GIT change tracking inside symlinks. If my symlink is to another folder in the same git repo I don't want the changed files showing up twice in Code's Git view.

mightypenguin commented Sep 14, 2016

It would be nice to have an option to NOT do GIT change tracking inside symlinks. If my symlink is to another folder in the same git repo I don't want the changed files showing up twice in Code's Git view.

@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Sep 14, 2016

Member

This issue is about displaying symlinks in the git view and what happens when you click them. Neither Code nor git follow (or should follow) the symlinks.

Member

joaomoreno commented Sep 14, 2016

This issue is about displaying symlinks in the git view and what happens when you click them. Neither Code nor git follow (or should follow) the symlinks.

@joaomoreno joaomoreno changed the title from Problems with adding symlinks to git repository to Can't open symlinks from git viewlet Sep 14, 2016

@mightypenguin

This comment has been minimized.

Show comment
Hide comment
@mightypenguin

mightypenguin Sep 15, 2016

Ok, off topic, but I am seeing VScode following symlinks in the git view. Running "git status" does not show these files. Should I create a new issue or discuss this somewhere else?

mightypenguin commented Sep 15, 2016

Ok, off topic, but I am seeing VScode following symlinks in the git view. Running "git status" does not show these files. Should I create a new issue or discuss this somewhere else?

@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Sep 15, 2016

Member

Can you take a screenshot to show me what you mean?

Member

joaomoreno commented Sep 15, 2016

Can you take a screenshot to show me what you mean?

@mightypenguin

This comment has been minimized.

Show comment
Hide comment
@mightypenguin

mightypenguin Sep 15, 2016

I know what causes it.
The git repo is a remotely mounted fuse file system.
The linux terminal shows permissions and symlinks properly, but for some reason vscode isn't.
If I create a simple git repo with a directory and a symlink to that directly it works properly on my local filesystem. If I move that to the fuse mounted file system it confuses vscode.

Here's my mount command:
sshfs hostname:/home/user/ /home/user/ -o sshfs_sync -o sync_readdir -o follow_symlinks -o kernel_cache -o max_background=50 -o big_writes

mightypenguin commented Sep 15, 2016

I know what causes it.
The git repo is a remotely mounted fuse file system.
The linux terminal shows permissions and symlinks properly, but for some reason vscode isn't.
If I create a simple git repo with a directory and a symlink to that directly it works properly on my local filesystem. If I move that to the fuse mounted file system it confuses vscode.

Here's my mount command:
sshfs hostname:/home/user/ /home/user/ -o sshfs_sync -o sync_readdir -o follow_symlinks -o kernel_cache -o max_background=50 -o big_writes

@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Sep 17, 2018

Member

Actually, no more errors when you click it. We handle it nicely, even with decorations.

Member

joaomoreno commented Sep 17, 2018

Actually, no more errors when you click it. We handle it nicely, even with decorations.

@joaomoreno joaomoreno closed this Sep 17, 2018

@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Sep 18, 2018

Member

We just can't handle the root being a symlink in itself.

Member

joaomoreno commented Sep 18, 2018

We just can't handle the root being a symlink in itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment