Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.28.0 unable to open terminal #60393

Closed
unional opened this issue Oct 9, 2018 · 11 comments
Closed

1.28.0 unable to open terminal #60393

unional opened this issue Oct 9, 2018 · 11 comments
Assignees
Labels
info-needed Issue requires more information from poster *not-reproducible Issue cannot be reproduced by VS Code Team member as described terminal Integrated terminal issues windows VS Code on Windows issues

Comments

@unional
Copy link

unional commented Oct 9, 2018

  • VSCode Version: 1.28.0
  • OS Version: Windows 10

Steps to Reproduce:

  1. Install 1.28.0 in user mode
  2. Open and launch terminal

Does this issue occur when all extensions are disabled?: Yes

It errors with:

The terminal process command 'C:\Program Files\Git\bin\bash.exe' failed to launch (exit code: 2)

The same goes for cmd.exe (the default).

By the way, in Windows, when I try to upgrade from background it fails with

image
There ARE other instances of VSCode running by other users. But no instance is running for the current user. That's probably a separate bug.

@vscodebot vscodebot bot added the terminal Integrated terminal issues label Oct 9, 2018
@unional
Copy link
Author

unional commented Oct 10, 2018

For the upgrade issue, it is mentioned and tracked in #60375

@Tyriar
Copy link
Member

Tyriar commented Oct 11, 2018

Does this path exist C:\Program Files\Git\bin\bash.exe? exit code 2 means the path doesn't exist. For cmd.exe what path are you using to test this? Are you on a corporate locked down machine?

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Oct 11, 2018
@unional
Copy link
Author

unional commented Oct 11, 2018

Yes it exists. When downgrade back to 1.27.2, it works fine.
the same problem when I switch back to cmd.exe it's the basic command prompt.
The paths are correct and it is not in a locked down machine.

@unional
Copy link
Author

unional commented Oct 17, 2018

This issue still exists in 1.28.2

@unional
Copy link
Author

unional commented Oct 18, 2018

If I install it twice (before opening it), then it works. Seems like there is some corruption during upgrade.

@Tyriar
Copy link
Member

Tyriar commented Oct 18, 2018

Ok, let me know if you see it again. Closing for now.

@Tyriar Tyriar added the *not-reproducible Issue cannot be reproduced by VS Code Team member as described label Oct 18, 2018
@vscodebot
Copy link

vscodebot bot commented Oct 18, 2018

We closed this issue because we are unable to reproduce the problem with the steps you describe. Chances are we've already fixed your problem in a recent version of VS Code. If not, please ask us to reopen the issue and provide us with more detail. Our issue reporting guidelines might help you with that.

Happy Coding!

@Tyriar Tyriar added the windows VS Code on Windows issues label Oct 18, 2018
@vscodebot vscodebot bot closed this as completed Oct 18, 2018
@unional
Copy link
Author

unional commented Oct 18, 2018

The corruption is due to #60375, so will see what happen after that is fixed.

@unional
Copy link
Author

unional commented Oct 18, 2018

Said too soon. After I close VSCode and reopen it, the issue still exists. So it is not related to upgrade.

Please reopen.

@unional
Copy link
Author

unional commented Oct 18, 2018

This is related to Workspace.

I have an additional setting in the workspace file:

{
  "settings": {
    "terminal.integrate.cwd": "..."
   }
}

That path is valid when the active project is "project-a" (I have "project-a" and "project-b" in the workspace) but not "project-b".

When the "project-b" is active (i.e. the currently active file is in "project-b"), the said path is invalid and causing the terminal fails to open (code 2).

@unional
Copy link
Author

unional commented Oct 18, 2018

Since this is not officially supported, we can keep this issue closed.

Reference:
#42661
#42165

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster *not-reproducible Issue cannot be reproduced by VS Code Team member as described terminal Integrated terminal issues windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

2 participants