New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote debugging issues after Node 10.12 #62354

Closed
roblourens opened this Issue Nov 1, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@roblourens
Member

roblourens commented Nov 1, 2018

Repro steps: #61711 (comment)

Or steps w/o docker:

  • Set up remote debugging, must be on a different actual disk, using node 10.12+
  • Set a BP, hit the BP
  • File opens again in a "read-only core module" file 馃悰

@roblourens roblourens added this to the October 2018 milestone Nov 1, 2018

@roblourens roblourens self-assigned this Nov 1, 2018

roblourens added a commit that referenced this issue Nov 1, 2018

@jeremychone

This comment has been minimized.

jeremychone commented Nov 1, 2018

@roblourens Yes, I just tested the insiders build and it was fixed on my simplified repo I made in the comment referenced. In the next couple of days I will test it on our full (with .map / .ts files) and report if I see any issue.

Thank you so much for your responsiveness. It might seem to be a corner case which is why people did not notice that much, but we have a Kubernetes centric development process, meaning all our dev process run on local Kubernetes managed containers during dev, and without this fix debugging would have become very cumbersome.

@weinand weinand added the verified label Nov 2, 2018

@weinand

This comment has been minimized.

Member

weinand commented Nov 2, 2018

works fine for me now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment