Apply excludes to editor history quick open too #6502

Closed
vsccarl opened this Issue May 18, 2016 · 4 comments

Projects

None yet

4 participants

@vsccarl
vsccarl commented May 18, 2016
  • VSCode Version: 1.1.0-alpha
  • OS Version: Windows 10

Related #3615

Steps to Reproduce:

I'm working in the smoke test repo (link)

  1. Use quick open Ctrl+P to open some files in node_modules folder (I just used index.js as it occurs a lot)
  2. Add in settings
"search.exclude": {
    "**/node_modules": true
}
  1. Use Ctrl+P type 'index.js'

The list of recent files still includes files located in /node_modules. I found a previous thread that says using Ctrl+K W will remove them, but excluding them in user settings should also apply to recently opened files without having to use a command to close/remove them.

@bpasero bpasero changed the title from Quick open includes recent files that are excluded in user settings to Apply excludes to editor history quick open too May 19, 2016
@bpasero bpasero added this to the Backlog milestone May 19, 2016
@bpasero bpasero self-assigned this May 19, 2016
@bpasero
Member
bpasero commented May 19, 2016

We should apply the excludes to the editor history too.

@bpasero bpasero removed their assignment Aug 17, 2016
@egamma egamma removed the v-test label Aug 22, 2016
@ChuckJonas

+1 on fixing this...

@ChuckJonas

I was very committed to using VS Code (authored 3 plugins for apex development and contributed to a 4th) but I'm sad to say abandoning it for now...

This bug killing my productivity (even caused me to introduce a production bug) and there is no viable work around.

Once you open an search excluded file, it will always seem to pop-up ahead of search included files. Even, if I exclude the file from the project, it still shows up.

@bpasero
Member
bpasero commented Jan 19, 2017

@ChuckJonas as a workaround there is a command "Clear Editor History" (removes all) and "Remove from Editor History" to remove an individual entry.

@bpasero bpasero self-assigned this Jan 19, 2017
@bpasero bpasero added a commit that closed this issue Jan 19, 2017
@bpasero bpasero fixes #6502 ef2d412
@bpasero bpasero closed this in ef2d412 Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment