New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Select for compare" and "Compare with selected" commands not shown for virtual documents #66681

Closed
johnspurlock opened this Issue Jan 17, 2019 · 3 comments

Comments

Projects
None yet
5 participants
@johnspurlock
Copy link

johnspurlock commented Jan 17, 2019

  • VSCode Version: 1.30.2
  • OS Version: macOS 10.14.2

Steps to Reproduce:

  1. Compile and run the virtual-document-sample.
  2. Extension host window -> Explorer view
  3. Ensure you have at least one "untitled" document open in "Open Editors"
  4. Create a cowsay virtual document: > cowsay
  5. Right-click the virtual document

Actual: the context menu for the virtual doc does not include the compare commands "Select for compare" and "Compare with selected". The context menu for the the untitled doc does.

Expected: context menu for virtual docs should include the compare commands.

Note: the hard part already seems to be implemented, can already compare a virtual doc with another doc by selecting the other doc first! But this workaround only works when a non-virtual document is present. Two virtual docs ought to be comparable in the same way. Just need to enable the commands.

@jrieken jrieken assigned bpasero and unassigned jrieken Jan 17, 2019

@bpasero bpasero assigned isidorn and unassigned bpasero Jan 18, 2019

@isidorn isidorn added this to the December/January 2019 milestone Jan 18, 2019

@isidorn

This comment has been minimized.

Copy link
Contributor

isidorn commented Jan 18, 2019

We will now show these actions for all items that have resources
This is a bit too much I believe, but let's wait for users to complain. I think this is a better approach now.

@isidorn isidorn closed this in da37926 Jan 18, 2019

@johnspurlock

This comment has been minimized.

Copy link
Author

johnspurlock commented Jan 18, 2019

Thank you!

@isidorn

This comment has been minimized.

Copy link
Contributor

isidorn commented Jan 18, 2019

Welcome. Try it out in monday vscode insiders and let us know if it works as you expect

@mjbvz mjbvz added the verified label Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment