Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid: Layout destroyed when problems panel is focused #67371

Closed
bpasero opened this issue Jan 29, 2019 · 6 comments
Closed

Grid: Layout destroyed when problems panel is focused #67371

bpasero opened this issue Jan 29, 2019 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug error-list Problems view layout General VS Code workbench layout issues verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jan 29, 2019

Refs #67308

  • have panel to the right
  • make it large enough so that panel titles are visible
  • click through elements as shown in the video
  • 🐛 layout explodes at the end

grid-tw

//cc @joaomoreno

@sbatten sbatten added the layout General VS Code workbench layout issues label Jan 29, 2019
@sbatten sbatten changed the title Grid: layout explodes in this case Grid: Layout destroyed when problems panel is focused Jan 30, 2019
@sbatten
Copy link
Member

sbatten commented Jan 30, 2019

looks like the problems pane creates a tree container offscreen (hidden behind the status bar and is the same height as the problems pane. the old layout doesn't break likely because of absolute positioning, but this may be an issue with the pane itself.

@bpasero
Copy link
Member Author

bpasero commented Jan 31, 2019

☝️ @isidorn / @sandy081

@sandy081
Copy link
Member

@sbatten Not sure what do you mean by offscreen here. Tree is properly placed inside the tree container without any absolute positioning. I do not understand how it breaks the layout.

@sbatten sbatten added the bug Issue identified by VS Code Team member as probable bug label Feb 4, 2019
@benrosenblum
Copy link

This occurs for me with the panel on the bottom as well.

@sbatten
Copy link
Member

sbatten commented Feb 12, 2019

@sandy081
image

There are 2 divs in the problems pane. One that contains the message and another empty one of the same height. When the message pane is visible, the empty one is pushed offscreen. (really it starts at the top of the status bar after the first div). When not using grid layout, this likely doesn't break anything because we absolutely position every part and don't allow overflow to offset the workbench. However, grid layout is different and breaks due to the div that should be hidden.

@sandy081
Copy link
Member

@sbatten So you say it happens only in grid layout? I will try it repro and see.

@sandy081 sandy081 self-assigned this Feb 13, 2019
@sandy081 sandy081 added this to the February 2019 milestone Feb 13, 2019
@bpasero bpasero added the verified Verification succeeded label Feb 25, 2019
@sandy081 sandy081 added the error-list Problems view label Mar 3, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug error-list Problems view layout General VS Code workbench layout issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants