Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors washed out after 1.31 upgrade #69135

Closed
dan-hughes opened this issue Feb 21, 2019 · 10 comments
Closed

Colors washed out after 1.31 upgrade #69135

dan-hughes opened this issue Feb 21, 2019 · 10 comments
Assignees
Labels
electron upstream
Milestone

Comments

@dan-hughes
Copy link

@dan-hughes dan-hughes commented Feb 21, 2019

Since the 1.31 release all the colors have a yellow hue to them. When I downgrade to 1.30 this issue goes away. I have updated GPU drivers and run with the --disable-gpu flag without any success.

I installed the insiders 1.32 build and the issue is still occurring, but the 1.31 exploration build #68893 does not have this issue.

Image comparison below.

1.31.1
image

1.30.2
image

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Feb 21, 2019

@bpasero dupe of #68893?

@bpasero bpasero added upstream electron electron-3.0.x-update labels Feb 21, 2019
@bpasero
Copy link
Member

@bpasero bpasero commented Feb 21, 2019

Yeah could be.

We are building exploration builds that use a much newer version of our UI framework (Electron version 4.0.x). I wonder if this issue reproduces with one of these builds, could you try? Download:

@bpasero bpasero added the needs more info label Feb 21, 2019
@dan-hughes
Copy link
Author

@dan-hughes dan-hughes commented Feb 21, 2019

Doesn't occur on the exploration build (I had already checked and mentioned above).

This does not happen on my other PC, so this could be something around my hardware.

CPUs Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2592)
GPU Nvidia P2000 / Intel UHD630
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
video_decode: enabled
video_encode: enabled webgl: enabled
webgl2: enabled
Memory (System) 31.78GB (24.29GB free)
Process Argv  
Screen Reader no
VM 0%

image

@bpasero bpasero added fixed-in-electron-4.0.x and removed needs more info labels Feb 21, 2019
@bryanhunwardsen
Copy link

@bryanhunwardsen bryanhunwardsen commented Jun 11, 2019

I have same issue updating to 1.36, not sure what ver I was coming from though.
Version: 1.36.0-insider (user setup)
Commit: c089daa
Date: 2019-06-07T05:19:15.188Z
Electron: 4.2.3
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.17763

image

@el
Copy link

@el el commented Jun 12, 2019

Same issue on ubuntu

Screenshot from 2019-06-12 17-18-43

@bpasero
Copy link
Member

@bpasero bpasero commented Jul 1, 2019

We will ship with Electron 4 with our upcoming release 1.36 this week. As such I am closing this issue. To benefit from the update already today, consider to use our insiders version: https://code.visualstudio.com/insiders/

@bpasero bpasero closed this Jul 1, 2019
@bpasero bpasero added this to the June 2019 milestone Jul 1, 2019
@felrib
Copy link

@felrib felrib commented Jul 4, 2019

Not sure if it's the same problem, but after 1.36 colors are a bit off. I'm using Ubuntu 19.04.

Using --force-color-profile=srgb makes no difference.

@michaelcacciatore
Copy link

@michaelcacciatore michaelcacciatore commented Jul 11, 2019

Turning off HDR on my primary monitor fixed the washed out colors (even though I was using VSCode on a secondary monitor). I'm on VSCode 1.36.1

@ta32
Copy link

@ta32 ta32 commented Aug 4, 2019

@bpasero this issue is still occuring in version 1.36.1 it looks like when you enable HDR vscode becomes washed out, can we reopen this issue?

@bpasero
Copy link
Member

@bpasero bpasero commented Aug 5, 2019

Got it. See #65816 for the related issue to allow to force the color profile as a setting (not having to pass it as command line argument).

People hitting this, can also please try out our new exploration builds with Electron 6:

We are building exploration builds that use a much newer version of our UI framework (Electron version 6.0.x). I wonder if this issue reproduces with one of these builds, could you try? Download:

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
electron upstream
Projects
None yet
Development

No branches or pull requests

8 participants