New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify shell command for Linux and OS X #77

Closed
jchannon opened this Issue Nov 18, 2015 · 15 comments

Comments

Projects
None yet
8 participants
@jchannon

jchannon commented Nov 18, 2015

Is there a shell command out of the box to launch VSCode?

Atom has atom
Sublime has subl

@egamma

This comment has been minimized.

Member

egamma commented Nov 18, 2015

VS Code has code

@egamma egamma closed this Nov 18, 2015

@jchannon

This comment has been minimized.

jchannon commented Nov 18, 2015

screen shot 2015-11-18 at 18 10 14

@lukehoban

This comment has been minimized.

Contributor

lukehoban commented Nov 18, 2015

On OS X, you need to follow the instructions here to invoke from the command line: https://code.visualstudio.com/Docs/editor/setup.

It would be nice to have an installer on OS X that configured this automatically.

@jchannon

This comment has been minimized.

jchannon commented Nov 18, 2015

Agreed. Not sure how atom and sublime do it

@egamma

This comment has been minimized.

Member

egamma commented Nov 18, 2015

apologies, forgot that it was a manual step for me on OS X.

@egamma egamma reopened this Nov 18, 2015

@Tyriar

This comment has been minimized.

Member

Tyriar commented Nov 18, 2015

On ubuntu for atom, this file is renamed from atom.sh and is put in /usr/bin/atom and /usr/share/atom

https://github.com/atom/atom/blob/1ee08be508f6892a6bd2f412d03dcb70de59ebe3/atom.sh

subl puts a file in the same location but it's much simpler, just calling in to the app.

#!/bin/sh
exec /opt/sublime_text/sublime_text "$@"
@jchannon

This comment has been minimized.

jchannon commented Nov 18, 2015

Unlike every other OSS library?

On Wednesday, 18 November 2015, Toni notifications@github.com wrote:

For future reference Githubs issue tracker is not for support or feature
suggestions. Feature suggestions already have a place over at vscodes
uservoice
https://visualstudio.uservoice.com/forums/293070-visual-studio-code and
you can ask for help on StackOverflow with the [vscode] tag
https://stackoverflow.com/questions/tagged/vscode


Reply to this email directly or view it on GitHub
#77 (comment).

@bpasero

This comment has been minimized.

Member

bpasero commented Nov 19, 2015

Closing, we have instructions for adding "code" to the path.

@bpasero bpasero closed this Nov 19, 2015

@jchannon

This comment has been minimized.

jchannon commented Nov 19, 2015

Not exactly a seamless user experience is it and seeing as the other
editors provide this for you out of the box and @egamma considers it a feature
I'd ask you to reopen this

On Thursday, 19 November 2015, Benjamin Pasero notifications@github.com
wrote:

Closed #77 #77.


Reply to this email directly or view it on GitHub
#77 (comment).

@joaomoreno joaomoreno reopened this Nov 19, 2015

@joaomoreno joaomoreno self-assigned this Nov 19, 2015

@joaomoreno

This comment has been minimized.

Member

joaomoreno commented Nov 19, 2015

This is valid and I want to fix it.

@joaomoreno joaomoreno changed the title from Shell command to launch VSCode to Simplify shell command for Linux and OS X Nov 19, 2015

@Tyriar

This comment has been minimized.

Member

Tyriar commented Nov 20, 2015

I created Microsoft/vscode-docs#46 in the docs to improve the script to allow you to continue using the terminal that spawned vscode.

@0xmohit

This comment has been minimized.

0xmohit commented Nov 20, 2015

It would be nice to see the binary being renamed from Code to code.

@mackenza

This comment has been minimized.

mackenza commented Nov 21, 2015

it's not just a matter of putting it on the path. It needs a decent shell script so that control returns to your terminal window. (like Atom and Sublime do)

Also, as @0xmohit points out, it's called Code and not code which makes a difference

@Tyriar

This comment has been minimized.

Member

Tyriar commented Nov 21, 2015

@mackenza my PR features a small script that does this, something similar should probably be included in the codebase eventually Microsoft/vscode-docs#46 to meet user expectations

@egamma egamma modified the milestone: Backlog Dec 10, 2015

@Tyriar Tyriar added mac linux labels Feb 3, 2016

@Tyriar Tyriar assigned Tyriar and unassigned joaomoreno Feb 3, 2016

@Tyriar Tyriar modified the milestones: Feb 2016, Backlog Feb 3, 2016

@egamma egamma referenced this issue Feb 4, 2016

Closed

February Iteration Plan #2616

92 of 97 tasks complete

@Tyriar Tyriar closed this in 8981819 Feb 9, 2016

@Tyriar

This comment has been minimized.

Member

Tyriar commented Feb 9, 2016

The script has been created, moving the OSX portion of this issue to #2859

@Tyriar Tyriar added the verified label Feb 29, 2016

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.