Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors sepcified in the themes are not rendered correctly. #9629

Closed
pmkary opened this issue Jul 22, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@pmkary
Copy link
Contributor

commented Jul 22, 2016

  • VSCode Version:
    Latest — 1.3.1
  • OS Version:
    OS X — 10.11.3

Hello,
I hope you're doing great today.

As I was designing a theme for Code, I noticed what renders is not what I've specified. I know that you may say fonts render with many shading so the final coloring may be changed and that's why I tried every color that I specified and even the background colors rendered incorrectly.

screen shot 2016-07-22 at 9 04 58 pm

I don't know if it's a feature (which if it is, it's really a bad one) or a bug. If this is a bug I really hope that this issue helps you. But if it's part of the architecture; how it applies to colors and how can I choose a color in a way that after your filter it looks the way I want?

Thanks a lot
Pouya

@pmkary

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2016

I did a bit more of experimenting, It seems that both Code and Sublime renders the colors same way. Why is that so? And how does one get the colors they want in the final render?

I also have tried to understand the filter, The color #141414 renders to #101010 which means:
rgb( 20, 20, 20 )rgb( 16, 16, 16 ) so 20% darker but in the #688CB5 to #52749F its: rgb( 104, 140, 181 )rgb( 83, 116, 159 ), and reduce ratios are strange:

  • 83 / 104 = 0.798076923076923
  • 116 / 140 = 0.828571428571429
  • 159 / 181 = 0.878453038674033

So I don't think it's just a percent based convertor. And I really can't figure out the process.
Would you please specify it?

@kieferrm

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2016

@bpasero any idea?

@pmkary

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2016

I think I found where the problem was. this link was very good, the problem was with the Gamma RGB and sRGB. It must be added to a documentation somewhere. I compiled my colors to sRGB and it now renders prefect.

TextMate is only available on OS X, so it's no wonder the specification had no explanation, but I guess you have to add it somewhere in your documentation that be very noticeable.

Thanks a lot...
Pouya

@pmkary pmkary closed this Jul 22, 2016

@bpasero bpasero assigned aeschli and unassigned bpasero Aug 5, 2016

@bpasero

This comment has been minimized.

Copy link
Member

commented Aug 5, 2016

@aeschli fyi

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.