No description provided.
Hi @olingern, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.
Sorry about the lack of guidance so far.
When I said keep them in memory I literally meant it as a variable in some scope. Don't use the storage service, since it will polute the storage and we don't care about having this information surviving between executions.
keep them in memory
Create an object, next to loadReleaseNotes that will serve as a cache and use version as a key for that cache.
I refactored to use a string instead of the storage service.
Is there a reason you'd prefer the cache be an object with a key over a regular string? Is there a use case where multiple versions would be cached and need to be accessed directly on an object?
@olingern, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Yeah, using the version as a key lets you read the current version's release notes as well as the next one, once you get an update notification.
@joaomoreno Got it. I updated the PR and rebased commit history to be a bit more clean. Let me know if this all goods good and if there's anything I can do to help get the tests passing.
Looks better! 👍
The problem is you need to merge the latest master onto your branch, do you mind doing this? That way our continuous integration tests will run on the PR.
add release not caching support
@joaomoreno I pulled the latest master branch, but opening the release notes opens in the browser each time now.
@joaomoreno opting to close this as I see the latest version of Insider's release opens in the browser.
@olingern The insider release will always open in the browser. The stable one opens in the product.
Thanks for the PR!