Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Cache release notes. Fixes #13257 #15050
Hi @olingern, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
referenced this pull request
Nov 5, 2016
Sorry about the lack of guidance so far.
When I said
keep them in memory I literally meant it as a variable in some scope. Don't use the storage service, since it will polute the storage and we don't care about having this information surviving between executions.
Create an object, next to
loadReleaseNotes that will serve as a cache and use
version as a key for that cache.
I refactored to use a string instead of the storage service.
Is there a reason you'd prefer the cache be an object with a key over a regular string? Is there a use case where multiple versions would be cached and need to be accessed directly on an object?