Update LICENSE.txt #17684

merged 3 commits into from Jan 12, 2017


None yet

3 participants


This is the correct writing for MIT License.
With this, you will get MIT licenses tab beside contributors tab.

@rohmanhm rohmanhm Update LICENSE.txt

Hi @rohmanhm, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.


@chrisdias chrisdias was assigned by egamma Dec 21, 2016
chrisdias requested changes Jan 11, 2017 edited View changes

@rohmanhm thanks for the PR, i think it is cool to get the License tab to show up in the repo. A couple of comments on the PR... Microsoft policy is to include the "All rights reserved." clause and omit the year. If you make these changes, will the license tab still show up in GitHub?

@rohmanhm rohmanhm Add "All rights reserved" text.

@chrisdias Done, sorry my bad miss one line, but now it's clear


Thanks for the change... also can we remove the copyright year?

"Copyright (c) Microsoft Corporation"

rohmanhm commented Jan 11, 2017 edited

Ok, hopefully last change request :).

After checking with our legal folks, can you do a range on the copyright year?

Copyright (c) 2015 - present Microsoft Corporation

This should still be valid and it will show up as a new tab.

@rohmanhm rohmanhm Add range on the copyright year

Yes, you can. I make a new commit and it's valid MIT License. You can keep going.


looks great!

@chrisdias chrisdias merged commit f3d33d6 into Microsoft:master Jan 12, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
continuous-integration/appveyor/pr AppVeyor build succeeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment