linux argument startup fix #17853

Merged
merged 1 commit into from Jan 3, 2017

Projects

None yet

5 participants

@mrdrogdrog
Contributor

You shouldn't put the the script's arguments in a variable without keeping them as a list because the arguments were merged and then splitted with whitespace. This results in a total mashup of tabs.

See Issue #17852

@mrdrogdrog mrdrogdrog linux argument startup fix
20bbbfa
@msftclas

Hi @mrdrogdrog, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@bpasero bpasero removed their assignment Jan 1, 2017
@joaomoreno joaomoreno added this to the January 2017 milestone Jan 3, 2017
@joaomoreno joaomoreno merged commit 5f5ae5b into Microsoft:master Jan 3, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@joaomoreno
Member

Thanks!

@Tyriar
Member
Tyriar commented Jan 25, 2017

@joaomoreno please cc me for Linux CLI stuff, this re-introduced this issue: c2935f2

@Tyriar
Member
Tyriar commented Jan 25, 2017 edited

Fixed by looping over the arg array for sudo instead of shifting it 289dbf7

@joaomoreno
Member

Ugh! Sorry about that. 🍺

@Tyriar
Member
Tyriar commented Jan 26, 2017

No worries, luckily the issue wasn't closed off so I spotted the regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment