Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for home/end key in IntelliSense #20156

Merged
merged 2 commits into from Apr 11, 2017

Conversation

@mlewand
Copy link
Contributor

mlewand commented Feb 8, 2017

This PR adds a support for home / end keys in IntelliSense. I had basically the very same expectaction / feeling as given in #18656.

Everything is pretty straight-forward except:

  • I wasn't able to locate tests for suggestWidget, listWidget, am I missing something?
  • I don't really know how to trigger details view (from end user perspective) so I couldn't test it. Please make sure to check it or provide me an example steps on how to trigger it.
  • I know nothing about Mac hotkeys, so the default mapping included only home and end key which are present on Windows / Linux.
mlewand added 2 commits Feb 8, 2017
…rt for details view/state is yet to come.
@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Feb 8, 2017

@mlewand, thanks for your PR! By analyzing the history of the files in this pull request, we identified @joaomoreno and @alexandrudima to be potential reviewers.

@msftclas

This comment has been minimized.

Copy link

msftclas commented Feb 8, 2017

Hi @mlewand, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@mlewand

This comment has been minimized.

Copy link
Contributor Author

mlewand commented Mar 8, 2017

Hi @joaomoreno just checking if there's any chance to have it reviewed any time soon? It was fairly simple PR, requiring to add few methods.

@joaomoreno joaomoreno added this to the March 2017 milestone Mar 9, 2017
@joaomoreno joaomoreno modified the milestones: March 2017, April 2017 Mar 30, 2017
@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Apr 11, 2017

Thanks!

@joaomoreno joaomoreno merged commit 8855ef9 into microsoft:master Apr 11, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.