New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid request id collisions in pendingRPCReplies #21406

Merged
merged 1 commit into from Mar 8, 2017

Conversation

Projects
None yet
4 participants
@nicksnyder
Contributor

nicksnyder commented Feb 25, 2017

lastMessageId should have same scope as pendingRPCReplies so different calls to createRPC can't have request id collisions.

Avoid request id collisions in pendingRPCReplies
lastMessageId should have same scope as pendingRPCReplies so different calls to createRPC can't have request id collisions.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 25, 2017

@nicksnyder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima and @egamma to be potential reviewers.

@nicksnyder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima and @egamma to be potential reviewers.

@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Feb 25, 2017

@nicksnyder,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@nicksnyder,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@alexandrudima alexandrudima added this to the March 2017 milestone Feb 27, 2017

nicksnyder added a commit to sourcegraph/vscode that referenced this pull request Feb 28, 2017

Fix "Got reply to unknown seq" console warning
Bug exposed by introduction of multiple workspaces
Upstream at Microsoft#21406
@alexandrudima

This comment has been minimized.

Show comment
Hide comment
@alexandrudima

alexandrudima Mar 8, 2017

Member

Nice catch! 👍 Thank you!

Member

alexandrudima commented Mar 8, 2017

Nice catch! 👍 Thank you!

@alexandrudima alexandrudima merged commit 7594dc6 into Microsoft:master Mar 8, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nicksnyder nicksnyder deleted the nicksnyder:patch-2 branch May 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment