GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds "workbench.action.forceCloseActiveEditor" to externalAPI
Declare revert() in interface IEditorInput
Implement ForceCloseEditorAction in actions.ts
Add ForceCloseEditorAction to main.contribution.ts
@misoguy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bpasero and @egamma to be potential reviewers.
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Microsoft Pull Request Bot
Thanks much better, added some minor feedback.
Maybe better workbench.action.revertAndCloseActiveEditor ?
Suggest to move this into editorActions.ts
I have added a commit to move this into vs/workbench/browser/parts/editor/editorActions.ts.
I have previously added it into vs/workbench/electron-browser/actions.ts
because i found the command "workbench.action.closeActiveEditor" to be at 2 files (actions.ts & editorActions.ts) and it seemed like main.contribution.ts was importing the CloseEditorAction from the one in vs/workbench/electron-browser/actions.ts.
It'd be nice if you could briefly explain the difference between the two files(actions.ts & editorActions.ts) with the same command "workbench.action.closeActiveEditor"
Revert and Close Editor
Change class name and Action ID