Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed keybinding json for backslash #21969

Merged

Conversation

@rpjproost
Copy link
Contributor

rpjproost commented Mar 4, 2017

Hello, this is a possible solution for issue #21657

Short description:
Check with regex whether backslash is found, if so add double backslash otherwise keybindings JSON will be invalid

@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Mar 4, 2017

@rpjproost, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima and @jrieken to be potential reviewers.

@msftclas

This comment has been minimized.

Copy link

msftclas commented Mar 4, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@rpjproost

This comment has been minimized.

Copy link
Contributor Author

rpjproost commented Mar 4, 2017

Also, duplicate issue #17688

@alexandrudima

This comment has been minimized.

Copy link
Member

alexandrudima commented Mar 8, 2017

Looks good to me. Thank you for the contribution!

@alexandrudima alexandrudima merged commit 3b1d3ff into microsoft:master Mar 8, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.