Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 'never show again' in Git Extension #24654

Conversation

@timbanaveen
Copy link

timbanaveen commented Apr 13, 2017

Fixes #24283

Adding one option 'Never show again' in git extension pop-up for old version. Storing it by using memento provided by context by VSCode

@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Apr 13, 2017

@timbanaveen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @joaomoreno and @dbaeumer to be potential reviewers.

@msftclas

This comment has been minimized.

Copy link

msftclas commented Apr 13, 2017

@timbanaveen,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@timbanaveen

This comment has been minimized.

Copy link
Author

timbanaveen commented Apr 13, 2017

@joaomoreno Please Review.

@joaomoreno joaomoreno added this to the April 2017 milestone Apr 13, 2017
@joaomoreno joaomoreno self-assigned this Apr 13, 2017
@joaomoreno joaomoreno merged commit 615ebe5 into microsoft:master Apr 13, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Apr 13, 2017

Thanks! 🍻

Went with a git.ignoreLegacyWarning setting instead of storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.