Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .mjs to known JavaScript file extensions #25747

Merged
merged 1 commit into from May 4, 2017

Conversation

Projects
None yet
4 participants
@bmeck
Copy link
Contributor

commented May 1, 2017

Also add .es6 in missing places

Add .mjs to known JavaScript file extensions
Also add .es6 in missing places
@mention-bot

This comment has been minimized.

Copy link

commented May 1, 2017

@bmeck, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bpasero and @egamma to be potential reviewers.

@msftclas

This comment has been minimized.

Copy link

commented May 1, 2017

@bmeck,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas

This comment has been minimized.

Copy link

commented May 1, 2017

@bmeck, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@msftclas msftclas added cla-signed and removed cla-required labels May 1, 2017

@kieferrm kieferrm requested a review from mjbvz May 1, 2017

@mjbvz mjbvz added this to the May 2017 milestone May 4, 2017

@mjbvz mjbvz merged commit d6c61a0 into microsoft:master May 4, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mjbvz

This comment has been minimized.

Copy link
Contributor

commented May 4, 2017

Thanks! This change should be in the next VSCode insiders build

aisamu added a commit to aisamu/ring that referenced this pull request Aug 8, 2018

Add support for javascript modules mime-type
Javascript's module system has a suggested `mjs` extension, which has received
some degree of adoption (Node [1]), tooling support (Babel [2], VSCode [3]), and
is already present on Google's JS Modules documentation [4].

The only requirement is that they're sent with JS's MIME.

[1] - http://2ality.com/2017/05/es-module-specifiers.html#why-new-extension
[2] - babel/babel#5624
[3] - microsoft/vscode#25747
[4] - https://developers.google.com/web/fundamentals/primers/modules

aisamu added a commit to aisamu/ring that referenced this pull request Aug 19, 2018

Add support for javascript modules mime-type
Javascript's module system has a suggested mjs extension, which has
received some degree of adoption (Node [1]), tooling support (Babel [2],
VSCode [3]), and is already present on Google's JS Modules documentation
[4].

The only requirement is that they're sent with JS's MIME.

[1] -
http://2ality.com/2017/05/es-module-specifiers.html#why-new-extension
[2] - babel/babel#5624
[3] - microsoft/vscode#25747
[4] - https://developers.google.com/web/fundamentals/primers/modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.