Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests to PHP grammar #26992

Merged
merged 2 commits into from May 22, 2017
Merged

Add more tests to PHP grammar #26992

merged 2 commits into from May 22, 2017

Conversation

@luxifer
Copy link
Contributor

luxifer commented May 20, 2017

Related to #26543 I added the tests to validate the new backported grammar from atom/language-php#196

@mention-bot
Copy link

mention-bot commented May 20, 2017

@luxifer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima to be a potential reviewer.

@msftclas
Copy link

msftclas commented May 20, 2017

@luxifer,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@aeschli aeschli merged commit 764dab3 into microsoft:master May 22, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aeschli
Copy link
Contributor

aeschli commented May 22, 2017

Thanks @luxifer !

@aeschli aeschli added this to the May 2017 milestone May 22, 2017
@aeschli aeschli added the php label May 22, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.