One click script for installing on linux #274
Conversation
This is critical for any cross platform application, an easy way to have the users quickly install and start using the application, please don't say it is stupid and trivial to do since it defeats the purpose of a product which should be designed as per the user and not as per the dev wizards think are trivial to implement.
|
Hi @thewhitetulip, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
thewhitetulip
changed the title
| echo "something went wrong with installing app" | ||
| fi | ||
|
|
||
| echo 'export PATH=$PATH:/usr/local/vscode' >> ~/.bashrc |
There was a problem hiding this comment.
NO. You install things into /usr/local, without tracking.
YOU WRITE THINGS INTO BASHRC!!! And apparently root's bashrc. What about people who don't use bash?
What's wrong with you?
This code isn't safe, it doesn't have undo command and it's tailored for one user only.
There was a problem hiding this comment.
no the bashrc isn't the root bashrc, it is the user's bashrc. I realize the folly now, there is no need to have vscode in the PATH variable!
What about people who don't use bash
See scripts like these start with one userbase, then slowly we modify the script to let it install with people who don't use bash, but at least bash users will be able to install it right? you don't sit down one night to write an install script for every possible scenario!! Incremental advances my good sir!
and No, it isn't tailored for one user only, it'll expand the ~ to the user which is executing the script. and ~/.bashrc is not root's bashrc it is the user's bashrc
|
In my opinion, such installation scripts belong in a distro-dependent package (since not all Unix systems are the same). For instance, there's a package for VSCode in the AUR that suitably installs the software on Arch Linux systems. |
|
Yes, there is (a bit outdated) package in Gentoo Portage Overlays. People want it packaged for Ubuntu and I presume for other major distros. No need for install script. |
|
@Enet4 No, there can be distro dependant packages and there can be install scripts, I am not a unix wizard that's why my script is crude, but it does suit my purpose though. Every major software for linux has a install script, or at least they provide a way to install them via shell commands ( see https://golang.org/doc/install). The thing about packaging is that someone has to build packages and that becomes a problem as the editor will get updates. Instead of that when someone wants to build from source and not have anything to do with the package, they use the install script. I do not understand why everyone here is so against making a script, of course you can't merge my script, but it can serve as a starting point. I do not believe you both are active linux users I mean the desktop not linux servers, had you used linux and installed things from the command line you'd have understood the great convenience of having an install script, because you not only. I believe the problem of "outdated" packages comes with node.js Also apart from the user's convenience, if we provide a install script then you give the user a good user experience, and it is good that they won't have to rely on someone to package this to others because this is such a beautiful IDE! Why doesn't this project want to be in control of the complete end to end user experience for linux? It feels like linux is being ignored here. |
It was wrong to add in the PATH variable because anyways we give the full path in the .desktop file, so removing the line
|
I'm fine with leaving the decision of whether to include a Linux installation script or not to the devs. But do note that usually the only thing the installation scripts do is create/link an executable in /usr/local/bin and copy the remaining contents to /usr/local/share. The system's package manager would be oblivious to the software, leaving the tasks of updating or installing to either the user or more scripts. I wouldn't call that friendly to Linux users at all. It's not that Microsoft is being unfriendly to them either, it was good enough in the first place that Linux is supported. Without repeating myself: that script might have worked for you, but I wouldn't recommend it for the reasons already mentioned. Nothing personal even. |
Yeah Linux isn't being ignored, well explained. I don't think there is any point in discussing this any further. |
|
We will not provide an installation script. We will, though, get into repositories (deb, rpm, etc) so people can install Code just as they install other packages. Closing this for now. |
|
@joaomoreno by the way, I have found out some basic bugs in Code like replace all not working over the entire file, I wonder who looks after the Issues raised over this repo |
|
No need to wonder, rest assured the VS Code team looks after them. |
This makes an entry of visual studio code in the main menu bar of Linux based Operating systems and gives a one click script to install VSCode to the
/usr/local/vscodefolder, using this script the menu bar can identify that VSCode is a development tool and the users won't have to do the manual stuff which is too boring and frankly ruins the reputation of such an amazing tool, Microsoft just revolutionized the way many write code on Linux, this is a statement which none of us imagined to be hearing ever.