Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement terminal rename action #28464

Merged
merged 5 commits into from Jun 12, 2017
Merged

Implement terminal rename action #28464

merged 5 commits into from Jun 12, 2017

Conversation

jammerware
Copy link
Contributor

@jammerware jammerware commented Jun 11, 2017 •
edited by Tyriar

Fixes #10023

@jammerware
Initial work on microsoft#10023.
d7757bd 
Modified terminalInstance to expose setTitle and fire the onTitleChanged event when it's called. Added workbench.action.terminal.rename contribution from the workbench and the action that fires when it's run.
@jammerware
Added deregistration for title change check on the terminal message e…
33e339e 
…vent.
@jammerware
Merged from master.
ab70428
@msftclas
Copy link

@jammerware,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@mention-bot
Copy link

@jammerware, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Tyriar and @bpasero to be potential reviewers.

@msftclas
Copy link

@jammerware, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@Tyriar Tyriar added this to the June 2017 milestone Jun 12, 2017
@Tyriar
Copy link
Member

Tyriar commented Jun 12, 2017

Thanks @jammerware, this is just what I was after. Made a few minor changed and merged, this should land in Insiders tomorrow 🎆

@Tyriar Tyriar merged commit 76bc7c0 into microsoft:master Jun 12, 2017
@Tyriar Tyriar mentioned this pull request Jun 12, 2017
Closed
@Tyriar Tyriar changed the title Topic/issue 10023 Implement terminal rename action Jun 12, 2017
@jammerware jammerware deleted the topic/issue-10023 branch July 30, 2017 11:31
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
June 2017
Development

Successfully merging this pull request may close these issues.

Integrated Terminal : Allow Renaming sessions
4 participants
@jammerware @msftclas @mention-bot @Tyriar