Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesAdd git stashing #29138
Add git stashing #29138
Conversation
This comment has been minimized.
This comment has been minimized.
msftclas
commented
Jun 20, 2017
@Krzysztof-Cieslak, |
This comment has been minimized.
This comment has been minimized.
CC: @joaomoreno |
This comment has been minimized.
This comment has been minimized.
@Krzysztof-Cieslak We don't really need to have the stashes in the model itself. This will just make git status slower since we'd need to call git once more in order to get the stashes. You can just make this call once one of the stash actions runs. Can you fix that? |
This comment has been minimized.
This comment has been minimized.
Yes, I'll rebase and fix it. |
This comment has been minimized.
This comment has been minimized.
Ready to review again. |
This comment has been minimized.
This comment has been minimized.
These changes are not formatted and violate some linting rules we have set. We have configured a git pre-commit hook to validate these for you, which gets set up when you run Also, this goes into infinite recursion. Next time, please run your changes before handing them over to us. Also, this condition will fail when index is zero. Also, I've added functionality to provide a stash message when stashing changes. I've fixed all that up. We do appreciate your contributions very much. But next time, try to follow the guidelines better so we make this smoother. |
This comment has been minimized.
This comment has been minimized.
Sorry for the trouble @joaomoreno, I haven't paid enough attention to this PR, indeed. My bad :( |
Krzysztof-Cieslak commentedJun 20, 2017
Addresses #1904 which is one of the oldest and most upvoted issues.
Adds 3 new commands for git integration:
git stash
git stash pop
using latest stashgit stash pop
with choosing stash