New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set placeholder text in SourceControlInputBox #29822
Set placeholder text in SourceControlInputBox #29822
Conversation
@huizhougit, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dbaeumer to be a potential reviewer. |
Is it failed because of this? But my changes should be nothing about it. Why? |
1f64e92
to
ab8263b
Compare
@joaomoreno I know this feature is not tagged as help-wanted but my extension relies on it. More important is I hope to do some contribution. Actually, this is my first contribution for vscode, even the first time for open source. Please let me know if I missed anything. |
@huizhougit You're not supposed to automatically translate strings. Can you recreate this PR without those translations? |
@joaomoreno Do you mean I should not change any of the json files? |
@huizhougit Exactly. |
ab8263b
to
e17a5f4
Compare
@joaomoreno It's updated |
Thanks! 🍻 |
Implement #24090