New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set placeholder text in SourceControlInputBox #29822

Merged
merged 1 commit into from Nov 8, 2017

Conversation

Projects
None yet
5 participants
@huizhougit
Contributor

huizhougit commented Jun 29, 2017

Implement #24090

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jun 29, 2017

@huizhougit, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dbaeumer to be a potential reviewer.

mention-bot commented Jun 29, 2017

@huizhougit, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dbaeumer to be a potential reviewer.

@huizhougit

This comment has been minimized.

Show comment
Hide comment
@huizhougit

huizhougit Jun 29, 2017

Contributor

411.44s$ gulp hygiene --silent
Warning: Cannot read property 'flags' of undefined
src/vs/workbench/parts/scm/electron-browser/scmViewlet.ts:13:13:Unused import: 'platform'
The command "gulp hygiene --silent" exited with 1.

Is it failed because of this? But my changes should be nothing about it. Why?

Contributor

huizhougit commented Jun 29, 2017

411.44s$ gulp hygiene --silent
Warning: Cannot read property 'flags' of undefined
src/vs/workbench/parts/scm/electron-browser/scmViewlet.ts:13:13:Unused import: 'platform'
The command "gulp hygiene --silent" exited with 1.

Is it failed because of this? But my changes should be nothing about it. Why?

@huizhougit

This comment has been minimized.

Show comment
Hide comment
@huizhougit

huizhougit Jun 30, 2017

Contributor

@joaomoreno I know this feature is not tagged as help-wanted but my extension relies on it. More important is I hope to do some contribution. Actually, this is my first contribution for vscode, even the first time for open source. Please let me know if I missed anything.

Contributor

huizhougit commented Jun 30, 2017

@joaomoreno I know this feature is not tagged as help-wanted but my extension relies on it. More important is I hope to do some contribution. Actually, this is my first contribution for vscode, even the first time for open source. Please let me know if I missed anything.

@joaomoreno joaomoreno added this to the Backlog milestone Jun 30, 2017

@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Aug 28, 2017

Member

@huizhougit You're not supposed to automatically translate strings. Can you recreate this PR without those translations?

Member

joaomoreno commented Aug 28, 2017

@huizhougit You're not supposed to automatically translate strings. Can you recreate this PR without those translations?

@huizhougit

This comment has been minimized.

Show comment
Hide comment
@huizhougit

huizhougit Aug 29, 2017

Contributor

@joaomoreno Do you mean I should not change any of the json files?

Contributor

huizhougit commented Aug 29, 2017

@joaomoreno Do you mean I should not change any of the json files?

@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno
Member

joaomoreno commented Aug 29, 2017

@huizhougit Exactly.

@huizhougit

This comment has been minimized.

Show comment
Hide comment
@huizhougit

huizhougit Aug 31, 2017

Contributor

@joaomoreno It's updated

Contributor

huizhougit commented Aug 31, 2017

@joaomoreno It's updated

@Microsoft Microsoft deleted a comment from msftclas Sep 27, 2017

@joaomoreno joaomoreno modified the milestones: Backlog, November 2017 Nov 8, 2017

@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Nov 8, 2017

Member

Thanks! 🍻

Member

joaomoreno commented Nov 8, 2017

Thanks! 🍻

@joaomoreno joaomoreno merged commit e17a5f4 into Microsoft:master Nov 8, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment