Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set placeholder text in SourceControlInputBox #29822

Merged

Conversation

huizhougit
Copy link
Contributor

Implement #24090

@mention-bot
Copy link

@huizhougit, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dbaeumer to be a potential reviewer.

@huizhougit
Copy link
Contributor Author

411.44s$ gulp hygiene --silent
Warning: Cannot read property 'flags' of undefined
src/vs/workbench/parts/scm/electron-browser/scmViewlet.ts:13:13:Unused import: 'platform'
The command "gulp hygiene --silent" exited with 1.

Is it failed because of this? But my changes should be nothing about it. Why?

@huizhougit
Copy link
Contributor Author

@joaomoreno I know this feature is not tagged as help-wanted but my extension relies on it. More important is I hope to do some contribution. Actually, this is my first contribution for vscode, even the first time for open source. Please let me know if I missed anything.

@joaomoreno joaomoreno added this to the Backlog milestone Jun 30, 2017
@joaomoreno
Copy link
Member

@huizhougit You're not supposed to automatically translate strings. Can you recreate this PR without those translations?

@huizhougit
Copy link
Contributor Author

@joaomoreno Do you mean I should not change any of the json files?

@joaomoreno
Copy link
Member

@huizhougit Exactly.

@huizhougit
Copy link
Contributor Author

@joaomoreno It's updated

@microsoft microsoft deleted a comment from msftclas Sep 27, 2017
@joaomoreno joaomoreno modified the milestones: Backlog, November 2017 Nov 8, 2017
@joaomoreno
Copy link
Member

Thanks! 🍻

@joaomoreno joaomoreno merged commit e17a5f4 into microsoft:master Nov 8, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants