New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ExtensionTipsService multi-root aware #32106

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@felixfbecker
Contributor

felixfbecker commented Aug 8, 2017

As described in #29242

Collects extension recommendations from all roots instead of only for the first root.

return [];
}).then<string[]>(null, err => [])
)
).then(flatten);

This comment has been minimized.

@sandy081

sandy081 Aug 24, 2017

Member

Also needed to de dup

@sandy081

sandy081 Aug 24, 2017

Member

Also needed to de dup

}, err => []);
return TPromise.join(
this.contextService.getWorkspace().roots.map(root =>
this.fileService.resolveContent(root.with({ path: root.path + '/.vscode/extensions.json' })).then(content => {

This comment has been minimized.

@sandy081

sandy081 Aug 24, 2017

Member

I would use the old way paths to construct the path. This will make construct the path as per the platform

@sandy081

sandy081 Aug 24, 2017

Member

I would use the old way paths to construct the path. This will make construct the path as per the platform

This comment has been minimized.

@felixfbecker

felixfbecker Aug 24, 2017

Contributor

That would use backslashes on Windows, which is not valid in a URI

@felixfbecker

felixfbecker Aug 24, 2017

Contributor

That would use backslashes on Windows, which is not valid in a URI

This comment has been minimized.

@sandy081

sandy081 Aug 25, 2017

Member

That would use backslashes on Windows

True, but it is a valid file path. Creating an URI using URI.file takes care of it
Good thing is it will hide the knowledge of path separators.

@sandy081

sandy081 Aug 25, 2017

Member

That would use backslashes on Windows

True, but it is a valid file path. Creating an URI using URI.file takes care of it
Good thing is it will hide the knowledge of path separators.

@sandy081 sandy081 modified the milestones: September 2017, August 2017 Aug 29, 2017

@sandy081

This comment has been minimized.

Show comment
Hide comment
@sandy081

sandy081 Sep 18, 2017

Member

Resolved the conflicts and pushed

Member

sandy081 commented Sep 18, 2017

Resolved the conflicts and pushed

@sandy081 sandy081 closed this Sep 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment