Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spelling of 'iff' and 'idenifier' #32401

Merged
merged 2 commits into from Aug 15, 2017

Conversation

@hikerpig
Copy link
Contributor

hikerpig commented Aug 13, 2017

No description provided.

@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Aug 13, 2017

@hikerpig, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bpasero and @sandy081 to be potential reviewers.

@msftclas

This comment has been minimized.

Copy link

msftclas commented Aug 13, 2017

@hikerpig,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas

This comment has been minimized.

Copy link

msftclas commented Aug 13, 2017

@hikerpig, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@weinand

This comment has been minimized.

Copy link
Member

weinand commented Aug 13, 2017

Sometimes we use "iff" in the meaning of "if and only if"
(see https://en.wikipedia.org/wiki/If_and_only_if)
But some of the comments looks bogus to me.

@hikerpig

This comment has been minimized.

Copy link
Contributor Author

hikerpig commented Aug 14, 2017

@weinand Thanks for your note. So I check again and see many of them looks just like typos, then I got the meaningful comments back in the next commit

@bpasero bpasero merged commit b104c7d into microsoft:master Aug 15, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bpasero bpasero added this to the August 2017 milestone Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.