New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #32822. Stop propagation keydown event when keybinding. #32826

Merged
merged 1 commit into from Sep 27, 2017

Conversation

Projects
None yet
6 participants
@mazamachi
Contributor

mazamachi commented Aug 19, 2017

Fix the bug in #32822 due to event propagation is not stopped when ctrl key is pressed during composition.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 19, 2017

@mazamachi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima and @rebornix to be potential reviewers.

mention-bot commented Aug 19, 2017

@mazamachi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima and @rebornix to be potential reviewers.

@alexandrudima

This comment has been minimized.

Show comment
Hide comment
@alexandrudima

alexandrudima Sep 27, 2017

Member

@mazamachi Thank you for your contribution. This makes good sense and fixes #32822 . The previous check was too strict (it also checked that no modifiers are pressed).

Member

alexandrudima commented Sep 27, 2017

@mazamachi Thank you for your contribution. This makes good sense and fixes #32822 . The previous check was too strict (it also checked that no modifiers are pressed).

@alexandrudima alexandrudima merged commit e28fbfa into Microsoft:master Sep 27, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment