New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for uninstalling extensions given paths to their .vsix files #34042

Merged
merged 2 commits into from Nov 10, 2017

Conversation

Projects
None yet
4 participants
@fabiospampinato
Contributor

fabiospampinato commented Sep 8, 2017

Fix for #33106.

I tried to touch as few things as possible and to reuse already available functions. Is it good enough?

I got a /Users/fabio/Dropbox/Projects/vscode/src/vs/code/node/cliProcessMain.ts is not formatted trying to commit the changes, I've no idea what that means.

@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Sep 11, 2017

Member

I got a /Users/fabio/Dropbox/Projects/vscode/src/vs/code/node/cliProcessMain.ts is not formatted trying to commit the changes, I've no idea what that means.

It means you should run Format Document before staging. In the team we all have "editor.formatOnSave": true in order to have the files always formatted.

Member

joaomoreno commented Sep 11, 2017

I got a /Users/fabio/Dropbox/Projects/vscode/src/vs/code/node/cliProcessMain.ts is not formatted trying to commit the changes, I've no idea what that means.

It means you should run Format Document before staging. In the team we all have "editor.formatOnSave": true in order to have the files always formatted.

@joaomoreno joaomoreno added this to the Backlog milestone Sep 11, 2017

@fabiospampinato

This comment has been minimized.

Show comment
Hide comment
@fabiospampinato

fabiospampinato Sep 12, 2017

Contributor

Thanks for the info.

It should be properly formatted now.

Contributor

fabiospampinato commented Sep 12, 2017

Thanks for the info.

It should be properly formatted now.

@msftgits msftgits removed the cla-signed label Sep 26, 2017

@Microsoft Microsoft deleted a comment from msftclas Sep 26, 2017

@Microsoft Microsoft deleted a comment from msftclas Sep 26, 2017

@fabiospampinato

This comment has been minimized.

Show comment
Hide comment
@fabiospampinato

fabiospampinato Nov 9, 2017

Contributor

@joaomoreno Is this PR going to get merged anytime soon?

Contributor

fabiospampinato commented Nov 9, 2017

@joaomoreno Is this PR going to get merged anytime soon?

@joaomoreno joaomoreno modified the milestones: Backlog, November 2017 Nov 10, 2017

@joaomoreno joaomoreno merged commit 38589d4 into Microsoft:master Nov 10, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Nov 10, 2017

Member

Thanks! 🍻

(Big PR backlog!)

Member

joaomoreno commented Nov 10, 2017

Thanks! 🍻

(Big PR backlog!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment