New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle user information in URI #34051

Merged
merged 1 commit into from Sep 15, 2017

Conversation

Projects
None yet
3 participants
@keegancsmith
Contributor

keegancsmith commented Sep 8, 2017

Without this change encoding an URL like
git+ssh://git@github.com/Microsoft/vscode.git results in
git+ssh://git%40github.com/Microsoft/vscode.git.

Handle user information in URI
Without this change encoding an URL like
`git+ssh://git@github.com/Microsoft/vscode.git` results in
`git+ssh://git%40github.com/Microsoft/vscode.git`.
@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Sep 8, 2017

@keegancsmith,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

msftclas commented Sep 8, 2017

@keegancsmith,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@jrieken

This comment has been minimized.

Show comment
Hide comment
@jrieken

jrieken Sep 15, 2017

Member

Thanks

Member

jrieken commented Sep 15, 2017

Thanks

@jrieken jrieken merged commit bedd750 into Microsoft:master Sep 15, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@keegancsmith keegancsmith deleted the keegancsmith:uri-userinfo branch Sep 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment