New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate event firing of onDidClose #34255

Merged
merged 1 commit into from Sep 13, 2017

Conversation

Projects
None yet
2 participants
@nicksnyder
Contributor

nicksnyder commented Sep 12, 2017

The dispose method already calls this._onDidClose.fire(this); as its last statement.

@jrieken

This comment has been minimized.

Show comment
Hide comment
@jrieken

jrieken Sep 13, 2017

Member

Thanks.

Member

jrieken commented Sep 13, 2017

Thanks.

@jrieken jrieken added this to the September 2017 milestone Sep 13, 2017

@jrieken jrieken merged commit 73ae855 into Microsoft:master Sep 13, 2017

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
license/cla All CLA requirements met.

@nicksnyder nicksnyder deleted the nicksnyder:patch-4 branch Nov 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment