New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain focus on stopped thread when stepping a multithreaded session #34401

Merged
merged 1 commit into from Sep 22, 2017

Conversation

Projects
None yet
2 participants
@DatGuyJonathan

DatGuyJonathan commented Sep 14, 2017

What does this PR do?

There are a couple of issues with multithreaded debugging. When a second thread gets the first stopped event, the UI does not autofocus to that thread. When the user steps the second thread, the UI switches focus to the first thread.

before

The proposed fix is to allow focus if the currently focused thread is different than the one that wants to be focused on. Also, only auto-focus to the first thread if there's only one thread.

after

What issues does this PR fix?

#34246

@DatGuyJonathan

This comment has been minimized.

Show comment
Hide comment
@DatGuyJonathan

DatGuyJonathan Sep 14, 2017

@isidorn Here's the PR we discussed.

DatGuyJonathan commented Sep 14, 2017

@isidorn Here's the PR we discussed.

@isidorn isidorn self-assigned this Sep 15, 2017

@isidorn isidorn added this to the September 2017 milestone Sep 15, 2017

@DatGuyJonathan

This comment has been minimized.

Show comment
Hide comment
@DatGuyJonathan

DatGuyJonathan Sep 22, 2017

@isidorn , I wanted to check-in with you on this issue. We are releasing our debugger extension soon and it would be great if we can debug multi-threaded without this issue. Do you need any more info from me?

DatGuyJonathan commented Sep 22, 2017

@isidorn , I wanted to check-in with you on this issue. We are releasing our debugger extension soon and it would be great if we can debug multi-threaded without this issue. Do you need any more info from me?

@isidorn isidorn merged commit d586fc6 into Microsoft:master Sep 22, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
@isidorn

This comment has been minimized.

Show comment
Hide comment
@isidorn

isidorn Sep 22, 2017

Contributor

@DatGuyJonathan thank you for your PR.
The second check if fine, however the first one now makes the thread switch more aggresivly. For instance if a user is inspecting thread A and thread B stops we will agresively focus thread B - which can be frustrating.
However I think it is fine for now and if we see users complaining we can revert this behavior.

Contributor

isidorn commented Sep 22, 2017

@DatGuyJonathan thank you for your PR.
The second check if fine, however the first one now makes the thread switch more aggresivly. For instance if a user is inspecting thread A and thread B stops we will agresively focus thread B - which can be frustrating.
However I think it is fine for now and if we see users complaining we can revert this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment