New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report tsserver response error as telemetry #34860

Merged
merged 1 commit into from Sep 25, 2017

Conversation

Projects
None yet
2 participants
@aozgaa
Contributor

aozgaa commented Sep 22, 2017

Adds a telemetry event to record errors generated by tsserver.

Note that this records all error-responses from tsserver except cancellations. This includes:

  • errors thrown while processing a request (we parse out the message and stack in this case)
  • requests that do not generate a response when one is expected
  • unrecognized JSON commands the server is asked to execute

These events should not be raised often, but part of the reason we would like to get information about these is that we really don't know, since tsserver swallows the errors and continues to run.

@mjbvz mjbvz self-requested a review Sep 22, 2017

@mjbvz mjbvz self-assigned this Sep 22, 2017

@mjbvz mjbvz merged commit c8f5358 into Microsoft:master Sep 25, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details

@mjbvz mjbvz added this to the September 2017 milestone Sep 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment